| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
@berkerpeksag, @terryjreedy: would you mind taking a look at this? |
Sorry, something went wrong.
There was a problem hiding this comment.
I'm not an sqllite3 expert by any means, so I'll leave verifying the content's accuracy to someone else ;).
Sorry, something went wrong.
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
|
Thanks for reviewing, @Fidget-Spinner, I appreciate your comments 😃 |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM! Thanks for improving the docs :).
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request. |
Sorry, something went wrong.
|
I have made the requested changes; please review again. |
Sorry, something went wrong.
|
Thanks for making the requested changes! @berkerpeksag: please review the changes made to this pull request. |
Sorry, something went wrong.
|
Ah, can you also fix the following error? Warning, treated as error:
[library/sqlite3:98] ":name" found in "cur.execute("select * from lang where lang_name=:name and lang_age=:age","
Makefile:49: recipe for target 'build' failed
You'll probably need to update Doc/tools/susp-ignored.csv. |
Sorry, something went wrong.
Oh, I've never seen this before :) c2366b5 did not fix it, but I discovered the make suspicious target in Doc. Fix comin' up pretty soon. UPDATE: Done. Fixed in f3ed86e |
Sorry, something went wrong.
|
Since this is a doc update, we'd want to backport it to 3.9 and 3.8, right? |
Sorry, something went wrong.
|
Thanks @erlend-aasland for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
Sorry, something went wrong.
(cherry picked from commit 3386ca0) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
|
GH-25402 is a backport of this pull request to the 3.9 branch. |
Sorry, something went wrong.
|
Thanks for reviewing, @berkerpeksag ! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Co-authored-by: Terry J. Reedy
https://bugs.python.org/issue20364