FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-20364: Improve sqlite3 placeholder docs by erlend-aasland · Pull Request #25003 · python/cpython · GitHub

/ cpython Public

bpo-20364: Improve sqlite3 placeholder docs - #25003

Merged
berkerpeksag merged 11 commits into
python:masterfrom
erlend-aasland:bpo-20364
Apr 14, 2021
Merged

bpo-20364: Improve sqlite3 placeholder docs#25003
berkerpeksag merged 11 commits into
python:masterfrom
erlend-aasland:bpo-20364

Conversation

erlend-aasland commented Mar 23, 2021
edited
Loading

Copy link
Copy Markdown
Contributor

Co-authored-by: Terry J. Reedy

https://bugs.python.org/issue20364

Copy link
Copy Markdown
Contributor Author

@berkerpeksag, @terryjreedy: would you mind taking a look at this?

Comment thread Doc/library/sqlite3.rst

Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not an sqllite3 expert by any means, so I'll leave verifying the content's accuracy to someone else ;).

Comment thread Doc/library/sqlite3.rst Outdated
Comment thread Doc/library/sqlite3.rst Outdated
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing, @Fidget-Spinner, I appreciate your comments 😃

Fidget-Spinner left a comment
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! Thanks for improving the docs :).

Comment thread Doc/library/sqlite3.rst
Comment thread Doc/library/sqlite3.rst Outdated
Comment thread Doc/includes/sqlite3/execute_1.py Outdated
Comment thread Doc/library/sqlite3.rst

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Comment thread Doc/includes/sqlite3/execute_1.py Outdated

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

Copy link
Copy Markdown

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

Copy link
Copy Markdown
Member

Ah, can you also fix the following error?

Warning, treated as error:
[library/sqlite3:98] ":name" found in "cur.execute("select * from lang where lang_name=:name and lang_age=:age","
Makefile:49: recipe for target 'build' failed

You'll probably need to update Doc/tools/susp-ignored.csv.

erlend-aasland commented Apr 14, 2021
edited
Loading

Copy link
Copy Markdown
Contributor Author

You'll probably need to update Doc/tools/susp-ignored.csv.

Oh, I've never seen this before :) c2366b5 did not fix it, but I discovered the make suspicious target in Doc. Fix comin' up pretty soon.

UPDATE: Done. Fixed in f3ed86e

Copy link
Copy Markdown
Contributor Author

Since this is a doc update, we'd want to backport it to 3.9 and 3.8, right?

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

erlend-aasland deleted the bpo-20364 branch April 14, 2021 12:29
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 14, 2021
(cherry picked from commit 3386ca0)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

Copy link
Copy Markdown

GH-25402 is a backport of this pull request to the 3.9 branch.

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing, @berkerpeksag !

berkerpeksag pushed a commit that referenced this pull request Apr 14, 2021
(cherry picked from commit 3386ca0)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL