FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-44106: Improve sqlite3 example database contents by erlend-aasland · Pull Request #26027 · python/cpython · GitHub

/ cpython Public

bpo-44106: Improve sqlite3 example database contents - #26027

Merged
berkerpeksag merged 9 commits into
python:mainfrom
erlend-aasland:sqlite-examples
May 19, 2021
ConversationCommits (9)ChecksFiles changed
Merged

bpo-44106: Improve sqlite3 example database contents#26027
berkerpeksag merged 9 commits into
python:mainfrom
erlend-aasland:sqlite-examples

Conversation

erlend-aasland commented May 10, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Use programming languages iso. politicians as example content.

https://bugs.python.org/issue44106

erlend-aasland commented May 10, 2021

Copy link
Copy Markdown
Contributor Author

Ref. #25003 (comment)

berkerpeksag requested changes May 11, 2021
View reviewed changes
Comment thread Doc/includes/sqlite3/execsql_fetchonerow.py Outdated
Comment thread Doc/includes/sqlite3/createdb.py
Comment thread Doc/includes/sqlite3/simple_tableprinter.py Outdated
Comment thread Misc/NEWS.d/next/Documentation/2021-05-11-00-54-14.bpo-44106.grCmuu.rst Outdated

bedevere-bot commented May 11, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

zware reviewed May 11, 2021
View reviewed changes
Comment thread Doc/includes/sqlite3/ctx_manager.py Outdated
Comment thread Doc/includes/sqlite3/insert_more_people.py

erlend-aasland commented May 11, 2021

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

bedevere-bot commented May 11, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

bedevere-bot requested a review from berkerpeksag May 11, 2021 07:10
Fidget-Spinner approved these changes May 11, 2021
View reviewed changes

Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks! I learnt something new about programming languages while learning about sqllite :).

Comment thread Doc/includes/sqlite3/createdb.py
erlend-aasland mentioned this pull request May 18, 2021
Merged
berkerpeksag merged commit 92d1064 into python:main May 19, 2021

miss-islington commented May 19, 2021

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

bedevere-bot commented May 19, 2021

Copy link
Copy Markdown

GH-26232 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2021
bpo-44106: Improve sqlite3 example database contents (pythonGH-26027)
d92c7f4 
(cherry picked from commit 92d1064)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2021
bpo-44106: Improve sqlite3 example database contents (pythonGH-26027)
3a0373e 
(cherry picked from commit 92d1064)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

bedevere-bot commented May 19, 2021

Copy link
Copy Markdown

GH-26233 is a backport of this pull request to the 3.9 branch.

berkerpeksag pushed a commit that referenced this pull request May 19, 2021
bpo-44106: Improve sqlite3 example database contents (GH-26027)
db20afe 
(cherry picked from commit 92d1064)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
berkerpeksag pushed a commit that referenced this pull request May 19, 2021
bpo-44106: Improve sqlite3 example database contents (GH-26027)
3185bc9 
(cherry picked from commit 92d1064)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
erlend-aasland mentioned this pull request May 19, 2021
Merged
erlend-aasland deleted the sqlite-examples branch May 19, 2021 07:47
pablogsal mentioned this pull request Jul 18, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zware zware left review comments
berkerpeksag berkerpeksag approved these changes
Fidget-Spinner Fidget-Spinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL