FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-30593: Document that sqlite3.Cursor.executescript disregards isolation_level by erlend-aasland · Pull Request #26220 · python/cpython · GitHub

/ cpython Public

bpo-30593: Document that sqlite3.Cursor.executescript disregards isolation_level - #26220

Merged
berkerpeksag merged 1 commit into
python:mainfrom
erlend-aasland:bpo-30593
May 19, 2021
ConversationCommits (1)ChecksFiles changed
Merged

bpo-30593: Document that sqlite3.Cursor.executescript disregards isolation_level#26220
berkerpeksag merged 1 commit into
python:mainfrom
erlend-aasland:bpo-30593

Conversation

erlend-aasland commented May 18, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot added awaiting review docs Documentation in the Doc dir labels May 18, 2021

erlend-aasland commented May 18, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@pablogsal I'm adding skip news to this. Can be backported to 3.10 and 3.9 (3.8 doesn't even get doc updates anymore, right?).

pablogsal commented May 18, 2021

Copy link
Copy Markdown
Member

@pablogsal I'm adding skip news to this. Can be backported to 3.10 and 3.9 (3.8 doesn't even get doc updates anymore, right?).

Yep, docs changes can almost always be backported!

erlend-aasland commented May 18, 2021

Copy link
Copy Markdown
Contributor Author

Yep, docs changes can almost always be backported!

All right :) Thanks.

erlend-aasland commented May 18, 2021

Copy link
Copy Markdown
Contributor Author

But I note that Berker chose only to apply backport labels for 3.10 and 3.9 to GH-26027. Maybe do likewise here?

pablogsal commented May 18, 2021

Copy link
Copy Markdown
Member

But I note that Berker chose only to apply backport labels for 3.10 and 3.9 to GH-26027. Maybe do likewise here?

I don't see personally any problem of improving the docs of all versions even if they are in sec fixes only, bit maybe I am missing some context...

berkerpeksag merged commit 9014437 into python:main May 19, 2021

miss-islington commented May 19, 2021

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2021
bpo-30593: Doc'ed that executescript() disregards isolation level (py…
b9461c1 
…thonGH-26220)

(cherry picked from commit 9014437)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

bedevere-bot commented May 19, 2021

Copy link
Copy Markdown

GH-26230 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label May 19, 2021
erlend-aasland deleted the bpo-30593 branch May 19, 2021 07:06
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2021
bpo-30593: Doc'ed that executescript() disregards isolation level (py…
3605012 
…thonGH-26220)

(cherry picked from commit 9014437)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

bedevere-bot commented May 19, 2021

Copy link
Copy Markdown

GH-26231 is a backport of this pull request to the 3.9 branch.

erlend-aasland commented May 19, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing, Berker & Pablo!

berkerpeksag commented May 19, 2021

Copy link
Copy Markdown
Member

I don't see personally any problem of improving the docs of all versions even if they are in sec fixes only, bit maybe I am missing some context...

It's because historically online documentation of security-fix-only branches weren't updated daily.

berkerpeksag pushed a commit that referenced this pull request May 19, 2021
bpo-30593: Doc'ed that executescript() disregards isolation level (GH…
76ed53c 
…-26220)

(cherry picked from commit 9014437)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
berkerpeksag pushed a commit that referenced this pull request May 19, 2021
bpo-30593: Doc'ed that executescript() disregards isolation level (GH…
1f483c0 
…-26220)

(cherry picked from commit 9014437)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
pablogsal mentioned this pull request Jul 18, 2021
Closed
erlend-aasland mentioned this pull request Jul 27, 2022
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

berkerpeksag berkerpeksag approved these changes
pablogsal pablogsal approved these changes
Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL