FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-43795 - Update Stable ABI dat. by orsenthil · Pull Request #25716 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-43795 - Update Stable ABI dat. - #25716

Closed
orsenthil wants to merge 1 commit into
python:masterfrom
orsenthil:abi_fix
ConversationCommits (1)ChecksFiles changed
Closed

bpo-43795 - Update Stable ABI dat.#25716
orsenthil wants to merge 1 commit into
python:masterfrom
orsenthil:abi_fix

Conversation

orsenthil commented Apr 29, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

PRs were failing with the check if generated files are up to date. For e.g this one.

The Stable ABI was updated here in this PR - #25315
The change in this diff was introduced here - 3cc481b

I had run make regen-limited-abi to recrete the stable abi manifest.

https://bugs.python.org/issue43774

orsenthil changed the title Update Stable ABI dat. bpo-43774 - Update Stable ABI dat. Apr 29, 2021
orsenthil commented Apr 29, 2021
View reviewed changes
Comment thread Doc/data/stable_abi.dat
PyFrozenSet_New
PyFrozenSet_Type
PyGC_Collect
PyGC_Disable

orsenthil Apr 29, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This doesn't look right to me and don't know how to read this.

This was the output of make regen-limited-abi

orsenthil Apr 29, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@encukou - Please verify if this is correct.

scoder Apr 29, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No, that's not correct. Those should stay in the file.

scoder Apr 29, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

They probably need to get added to Misc/stable_abi.txt now. That seems to be the new source of truth. I'll add them there.

orsenthil Apr 29, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@scoder - Thank you. I could update this PR with Misc/stable_abi.txt change too.

orsenthil Apr 29, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Petr took care of it - #25720

orsenthil requested a review from encukou April 29, 2021 11:57
orsenthil changed the title bpo-43774 - Update Stable ABI dat. bpo-43795 - Update Stable ABI dat. Apr 29, 2021
orsenthil mentioned this pull request Apr 29, 2021
Merged
orsenthil requested a review from scoder April 29, 2021 12:49
markshannon mentioned this pull request Apr 29, 2021
Merged

encukou commented Apr 29, 2021

Copy link
Copy Markdown
Member

Oh, these are new symbols that got in as I merged PEP 652 commit. Sorry for the mismatch; I'll add them.
Details are in PEP 652, while I'm finishing up proper docs.

orsenthil commented Apr 29, 2021

Copy link
Copy Markdown
Member Author

Updating this PR at the correct location.

encukou commented Apr 29, 2021

Copy link
Copy Markdown
Member

See GH-25720

orsenthil commented Apr 29, 2021

Copy link
Copy Markdown
Member Author

Thank you. This is resolved by #25720

orsenthil closed this Apr 29, 2021
orsenthil deleted the abi_fix branch April 29, 2021 16:04
encukou mentioned this pull request Jun 7, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner Awaiting requested review from vstinner
serhiy-storchaka Awaiting requested review from serhiy-storchaka
encukou Awaiting requested review from encukou
scoder Awaiting requested review from scoder

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL