Repository navigation
bpo-43795: Generate python3dll.c and doc data from manifest (PEP 652) - #25315
Merged
encukou merged 15 commits intoApr 29, 2021
Merged
encukou merged 15 commits into
encukou merged 15 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Each section is sorted to reduce diffs (review effort) when the file becomes generated. Sort is done with key=str.lower to preserve most of the original order (underscored items first).
Copy link
Copy Markdown
Member
Author
|
I anticipate discussions taking a while, so I also opened #25312 to reduce diffs for reviewers. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
👍 No problem, go ahead :) |
Sorry, something went wrong.
PyMarshal_*, PyMember_{Get,Set}One, PyThreadState_DeleteCurrent,
Py_GetArgcArgv are not declared with Py_LIMITED_API,
so they're not part of the limited API. They stay in the stable ABI, though.
PyInterpreterState_GetID part of limited API and stable ABI.
PyOS_ReadlineFunctionPointer is removed from the stable ABI records,
as functions expecting FILE* are not part of the ABI. Ssee bpo-43868.
encukou
marked this pull request as ready for review
April 24, 2021 07:00
Copy link
Copy Markdown
Member
Author
|
Despite some buildbots timing out os failing socket, I call this ready for review. |
Sorry, something went wrong.
This was referenced Apr 29, 2021
This was referenced Apr 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's an initial stab at PEP 652 – Maintaining the Stable ABI
There are two reviews I'm looking for:
(Docs, tests and more file generators/checks to come later.)
https://bugs.python.org/issue43795