FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the test suite by pablogsal · Pull Request #26542 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the test suite - #26542

Merged
pablogsal merged 2 commits into
python:mainfrom
pablogsal:bpo-38323
Jun 4, 2021
ConversationCommits (2)ChecksFiles changed
Merged

bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the test suite#26542
pablogsal merged 2 commits into
python:mainfrom
pablogsal:bpo-38323

Conversation

pablogsal commented Jun 4, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

pablogsal requested review from 1st1 and asvetlov as code owners June 4, 2021 22:49
bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jun 4, 2021
pablogsal mentioned this pull request Jun 4, 2021
Closed
pablogsal requested a review from cjerdonek June 4, 2021 22:50

pablogsal commented Jun 4, 2021

Copy link
Copy Markdown
Member Author

@cjerdonek could you take a look?

cjerdonek approved these changes Jun 4, 2021
View reviewed changes

cjerdonek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yeah, that looks fine.

cjerdonek reviewed Jun 4, 2021
View reviewed changes
Comment thread Lib/test/test_asyncio/test_subprocess.py Outdated
pablogsal merged commit f171877 into python:main Jun 4, 2021
pablogsal deleted the bpo-38323 branch June 4, 2021 23:33

miss-islington commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

Sorry @pablogsal, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker f171877ebe276749f31386baed5841ce37cbee2e 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 4, 2021
bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the t…
c48ccc3 
…est suite (pythonGH-26542)

(cherry picked from commit f171877)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>

bedevere-bot commented Jun 4, 2021

Copy link
Copy Markdown

GH-26543 is a backport of this pull request to the 3.9 branch.

miss-islington commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

bedevere-bot commented Jun 4, 2021

Copy link
Copy Markdown

GH-26544 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 4, 2021
bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the t…
ff6097c 
…est suite (pythonGH-26542)

(cherry picked from commit f171877)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull request Jun 5, 2021
bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the t…
b3c50b2 
…est suite (GH-26542)

(cherry picked from commit f171877)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Jun 5, 2021
bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the t…
0d441d2 
…est suite (GH-26542) (GH-26544)

(cherry picked from commit f171877)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>

vstinner commented Jun 7, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member 
 @unittest.skip("[bpo-38323](https://bugs.python.org/issue38323): MultiLoopChildWatcher has a race condition

FYI if a skip message contains "bpo-xxx", a buildbot fails when a PR is merged and the buildbot logs contain the skip message, the PR will be attached to bpo-xxx.

IMO the bot attaching PRs to bpo issues should only look into the PR title, not in PR comments.

pablogsal commented Jun 7, 2021

Copy link
Copy Markdown
Member Author

FYI if a skip message contains "bpo-xxx", a buildbot fails when a PR is merged and the buildbot logs contain the skip message, the PR will be attached to bpo-xxx.

Well, hopefully soon we can merge some form of your PR and then remove that skip :)

miss-islington commented Jun 11, 2021

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

bedevere-bot commented Jun 11, 2021

Copy link
Copy Markdown

GH-26670 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2021
bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the t…
5c750ad 
…est suite (pythonGH-26542)

(cherry picked from commit f171877)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Jun 12, 2021
bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the t…
af5fb67 
…est suite (GH-26542) (GH-26670)

(cherry picked from commit f171877)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal mentioned this pull request Jul 18, 2021
Closed
vstinner mentioned this pull request Apr 10, 2022
Closed
kumaraditya303 mentioned this pull request Jul 18, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
1 more reviewer
cjerdonek cjerdonek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

pablogsal

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL