FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-82504: deprecate the MultiLoopChildWatcher by graingert · Pull Request #94648 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-82504: deprecate the MultiLoopChildWatcher - #94648

Closed
graingert wants to merge 16 commits into
python:mainfrom
graingert:deprecate-multi-loop-watcher
ConversationCommits (16)ChecksFiles changed
Closed

gh-82504: deprecate the MultiLoopChildWatcher#94648
graingert wants to merge 16 commits into
python:mainfrom
graingert:deprecate-multi-loop-watcher

Conversation

graingert commented Jul 7, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

graingert changed the title bpo-82504: deprecate the MultiLoopChildWatcher gh-82504: deprecate the MultiLoopChildWatcher Jul 7, 2022
graingert mentioned this pull request Jul 7, 2022
Closed
graingert marked this pull request as ready for review July 7, 2022 09:18
graingert requested review from 1st1 and asvetlov as code owners July 7, 2022 09:18
kumaraditya303 requested changes Jul 18, 2022
View reviewed changes

kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It would be better to add What's New entry about this deprecation.

Update Misc/NEWS.d/next/Library/2022-07-07-09-04-49.gh-issue-82504.6x…
ae826fa 
…tYAz.rst

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
graingert commented Jul 18, 2022
View reviewed changes
Comment thread Doc/library/asyncio-policy.rst Outdated
graingert commented Jul 18, 2022
View reviewed changes
Comment thread Doc/library/asyncio-policy.rst Outdated
kumaraditya303 reviewed Jul 18, 2022
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Outdated
graingert commented Jul 18, 2022
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst
graingert force-pushed the deprecate-multi-loop-watcher branch from 84a0ca0 to 2e6e996 Compare July 18, 2022 16:20
graingert requested a review from kumaraditya303 July 18, 2022 16:21
kumaraditya303 approved these changes Jul 18, 2022
View reviewed changes

kumaraditya303 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

graingert commented Jul 18, 2022

Copy link
Copy Markdown
Contributor Author

thanks for the review @kumaraditya303 !

kumaraditya303 commented Jul 18, 2022

Copy link
Copy Markdown
Contributor

@gvanrossum Would you like to review this? This deprecates MultiLoopChildWatcher which has race conditions so it is not even tested on CI currently, skipped on CI as of #26542.

gvanrossum commented Jul 18, 2022

Copy link
Copy Markdown
Member

I'm sorry, I don't feel comfortable reviewing this. Any core dev CC'ed on the issue would be more qualified than me.

gvanrossum removed their request for review July 18, 2022 23:12

graingert commented Jul 19, 2022

Copy link
Copy Markdown
Contributor Author

@kumaraditya303 can you request @njsmith on this?

kumaraditya303 commented Oct 9, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Superseded by #98089

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood left review comments
kumaraditya303 kumaraditya303 approved these changes
1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
njsmith Awaiting requested review from njsmith
vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL