FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-82504: deprecate the MultiLoopChildWatcher by graingert · Pull Request #94648 · python/cpython · GitHub

Repository navigation

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension .py  (2) .rst  (3) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
1 change: 1 addition & 0 deletions Doc/library/asyncio-policy.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ implementation used by the asyncio event loop:
:py:data:`SIGCHLD` is received).

.. versionadded:: 3.8
.. deprecated-removed:: 3.12 3.14

.. class:: SafeChildWatcher

Expand Down
12 changes: 12 additions & 0 deletions Doc/whatsnew/3.12.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,18 @@ CPython bytecode changes
Deprecated
==========

The following modules and APIs have been deprecated in this Python release,
and will be removed in Python 3.14.

APIs:

* :class:`asyncio.MultiLoopChildWatcher` (:gh:`94648`)

The following APIs were deprecated in this Python release and will be removed,
although there is currently no date scheduled for their removal.

APIs:

* :class:`typing.Hashable` and :class:`typing.Sized` aliases for :class:`collections.abc.Hashable`
and :class:`collections.abc.Sized`. (:gh:`94309`.)

Expand Down
1 change: 1 addition & 0 deletions Lib/asyncio/unix_events.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -1229,6 +1229,7 @@ class MultiLoopChildWatcher(AbstractChildWatcher):
# but retrieves the current loop by get_running_loop()

def __init__(self):
warnings._deprecated("asyncio.MultiLoopChildWatcher", remove=(3, 14))
self._callbacks = {}
self._saved_sighandler = None

Expand Down
12 changes: 5 additions & 7 deletions Lib/test/test_asyncio/test_subprocess.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -666,13 +666,6 @@ class SubprocessThreadedWatcherTests(SubprocessWatcherMixin,

Watcher = unix_events.ThreadedChildWatcher

@unittest.skip("bpo-38323: MultiLoopChildWatcher has a race condition \
and these tests can hang the test suite")
class SubprocessMultiLoopWatcherTests(SubprocessWatcherMixin,
test_utils.TestCase):

Watcher = unix_events.MultiLoopChildWatcher

class SubprocessSafeWatcherTests(SubprocessWatcherMixin,
test_utils.TestCase):

Expand Down Expand Up @@ -701,6 +694,11 @@ class SubprocessPidfdWatcherTests(SubprocessWatcherMixin,
Watcher = unix_events.PidfdChildWatcher


class MultiLoopChildWatcherTests(unittest.TestCase):
def test_deprecated(self):
with self.assertWarns(DeprecationWarning):
asyncio.MultiLoopChildWatcher()

class GenericWatcherTests(test_utils.TestCase):

def test_create_subprocess_fails_with_inactive_watcher(self):
Expand Down
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Deprecate :class:`asyncio.MultiLoopChildWatcher` to be removed in Python 3.14.

Back | FazBrowse Home | New Git URL