FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.9] bpo-38820: Test with OpenSSL 3.0.0 final (GH-28205) by ambv · Pull Request #28217 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[3.9] bpo-38820: Test with OpenSSL 3.0.0 final (GH-28205) - #28217

Merged
ambv merged 2 commits into
python:3.9from
ambv:backport-cc7c680-3.9
Sep 8, 2021
ConversationCommits (2)ChecksFiles changed
Merged

[3.9] bpo-38820: Test with OpenSSL 3.0.0 final (GH-28205)#28217
ambv merged 2 commits into
python:3.9from
ambv:backport-cc7c680-3.9

Conversation

ambv commented Sep 7, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Signed-off-by: Christian Heimes christian@python.org.
(cherry picked from commit cc7c680)

Co-authored-by: Christian Heimes christian@python.org

https://bugs.python.org/issue38820

[3.9] bpo-38820: Test with OpenSSL 3.0.0 final (pythonGH-28205)
573b8ee 
Signed-off-by: Christian Heimes <christian@python.org>.
(cherry picked from commit cc7c680)

Co-authored-by: Christian Heimes <christian@python.org>
ambv requested a review from tiran as a code owner September 7, 2021 17:09
bedevere-bot mentioned this pull request Sep 7, 2021
Merged
ambv commented Sep 7, 2021
View reviewed changes
Comment thread Tools/ssl/multissltests.py
Comment on lines +413 to +416
if not os.path.isdir(self.lib_dir):
# 3.0.0-beta2 uses lib64 on 64 bit platforms
lib64 = self.lib_dir + "64"
os.symlink(lib64, self.lib_dir)

ambv Sep 7, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Seems like this change causes all SSL tests to fail on 3.9?

tiran Sep 8, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

That seems unlikely. The _post_install_300 function is only executed if self.version.startswith("3.0").

tiran Sep 8, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I have bisected the failing tests in 3.9. Tests are passing in commit for tag v3.9.7. Current 3.9 is failing. The issue was introduced in c967bd5 (GH-28153).

@serhiy-storchaka please take a look

serhiy-storchaka Sep 8, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you @tiran. Shame on me. I have no idea how could I miss these warnings.

#28236 should fix it.

tiran Sep 8, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I guess you didn't notice because the tests were skipped. Additional OpenSSL tests are only executed for some changes:

cpython/.github/workflows/build.yml

Line 53 in c11956a

git diff --name-only origin/$GITHUB_BASE_REF.. | grep -qE '(ssl|hashlib|hmac|^.github)' && echo '::set-output name=run_ssl_tests::true' || true

ambv merged commit 7a6178a into python:3.9 Sep 8, 2021
ambv deleted the backport-cc7c680-3.9 branch September 8, 2021 17:01
tiran mentioned this pull request Apr 11, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tiran Awaiting requested review from tiran
serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL