FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.9] bpo-38820: Test with OpenSSL 3.0.0 final (GH-28205) by ambv · Pull Request #28217 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[3.9] bpo-38820: Test with OpenSSL 3.0.0 final (GH-28205) #28217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 2 commits into from
Sep 8, 2021
Conversation 5 Commits 2 Checks 0 Files changed
Merged

[3.9] bpo-38820: Test with OpenSSL 3.0.0 final (GH-28205) #28217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
573b8ee
[3.9] bpo-38820: Test with OpenSSL 3.0.0 final (GH-28205)
tiran Sep 7, 2021
a883f09
Merge remote-tracking branch '3.9' into backport-cc7c680-3.9
ambv Sep 8, 2021
File filter

Filter by extension

Filter by extension .py  (1) .yml  (1) All 2 file types selected
Only manifest files
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ jobs:
strategy:
fail-fast: false
matrix:
openssl_ver: [1.0.2u, 1.1.0l, 1.1.1l, 3.0.0-beta1]
openssl_ver: [1.0.2u, 1.1.0l, 1.1.1l, 3.0.0]
env:
OPENSSL_VER: ${{ matrix.openssl_ver }}
MULTISSL_DIR: ${{ github.workspace }}/multissl
Expand Down
6 changes: 5 additions & 1 deletion Tools/ssl/multissltests.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@

OPENSSL_RECENT_VERSIONS = [
"1.1.1l",
"3.0.0-beta1"
"3.0.0"
]

LIBRESSL_OLD_VERSIONS = [
Expand Down Expand Up @@ -410,6 +410,10 @@ def _post_install_300(self):
["make", "-j1", "install_ssldirs", "install_fips"],
cwd=self.build_dir
)
if not os.path.isdir(self.lib_dir):
# 3.0.0-beta2 uses lib64 on 64 bit platforms
lib64 = self.lib_dir + "64"
os.symlink(lib64, self.lib_dir)
Comment on lines +413 to +416

ambv Sep 7, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Seems like this change causes all SSL tests to fail on 3.9?

tiran Sep 8, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

That seems unlikely. The _post_install_300 function is only executed if self.version.startswith("3.0").

tiran Sep 8, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I have bisected the failing tests in 3.9. Tests are passing in commit for tag v3.9.7. Current 3.9 is failing. The issue was introduced in c967bd5 (GH-28153).

@serhiy-storchaka please take a look

serhiy-storchaka Sep 8, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you @tiran. Shame on me. I have no idea how could I miss these warnings.

#28236 should fix it.

tiran Sep 8, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I guess you didn't notice because the tests were skipped. Additional OpenSSL tests are only executed for some changes:

cpython/.github/workflows/build.yml

Line 53 in c11956a

git diff --name-only origin/$GITHUB_BASE_REF.. | grep -qE '(ssl|hashlib|hmac|^.github)' && echo '::set-output name=run_ssl_tests::true' || true


@property
def short_version(self):
Expand Down
Back | FazBrowse Home | New Git URL