FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix typos in the Include directory by cclauss · Pull Request #28745 · python/cpython · GitHub

Repository navigation

Fix typos in the Include directory - #28745

Merged
gpshead merged 1 commit into
python:mainfrom
cclauss:codespell-Include
Oct 6, 2021
Merged

gpshead merged 1 commit into
python:mainfrom
cclauss:codespell-Include

Conversation

cclauss commented Oct 5, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Like #28744 but for the Include directory.

[skip issue] Opening a related issue is pending python/psf-infra-meta#130

gpshead added skip issue skip news docs Documentation in the Doc dir labels Oct 6, 2021
gpshead merged commit 8e8f752 into python:main Oct 6, 2021

gpshead commented Oct 6, 2021

Copy link
Copy Markdown
Member

Thanks! FWIW some people find fixing up typos to be contentious as it can be seen as churn. Feel free to loop me in as a reviewer on any CPython PRs for comment/docs typo fixes. They do improve our codebase overall and when done as this one is, across a bunch of files at once systematically, reduce the plethora of future random PRs from people over time fixing just one thing at a time.

ambv commented Oct 6, 2021

Copy link
Copy Markdown
Contributor

@cclauss, just like elsewhere, we'll appreciate a manual [3.10] and [3.9] version of this PR to help us avoid future backport conflicts.

Copy link
Copy Markdown
Contributor

Thanks @cclauss for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

Copy link
Copy Markdown
Contributor

Thanks @cclauss for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

Copy link
Copy Markdown
Contributor

Sorry, @cclauss and @gpshead, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8e8f7522171ef82f2f5049940f815e00e38c6f42 3.9

Copy link
Copy Markdown
Contributor

Sorry @cclauss and @gpshead, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 8e8f7522171ef82f2f5049940f815e00e38c6f42 3.10

gpshead commented Oct 6, 2021

Copy link
Copy Markdown
Member

(apparently this one does need to be done manually, had to check :)

ambv commented Oct 6, 2021

Copy link
Copy Markdown
Contributor

If a sweeping change worked across branches, I'd be super surprised :D

cclauss deleted the codespell-Include branch October 6, 2021 20:30

cclauss commented Oct 6, 2021

Copy link
Copy Markdown
Contributor Author

@gpshead Thanks for your guidance. There are four more PRs to review if you have time/interest. https://github.com/python/cpython/pulls/cclauss

@ambv I will go at the backports in my morning.

Copy link
Copy Markdown

GH-28788 is a backport of this pull request to the 3.9 branch.

cclauss added a commit to cclauss/cpython that referenced this pull request Oct 7, 2021

Copy link
Copy Markdown

GH-28789 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit that referenced this pull request Oct 7, 2021
miss-islington pushed a commit that referenced this pull request Oct 7, 2021

cclauss commented Oct 7, 2021

Copy link
Copy Markdown
Contributor Author

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL