FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-45608: Document missing `sqlite3` DB-API attributes and methods by erlend-aasland · Pull Request #29219 · python/cpython · GitHub

/ cpython Public

bpo-45608: Document missing sqlite3 DB-API attributes and methods - #29219

Merged
ambv merged 7 commits into
python:mainfrom
erlend-aasland:sqlite-doc-dbapi
Oct 28, 2021
ConversationCommits (7)ChecksFiles changed
Merged

bpo-45608: Document missing sqlite3 DB-API attributes and methods#29219
ambv merged 7 commits into
python:mainfrom
erlend-aasland:sqlite-doc-dbapi

Conversation

erlend-aasland commented Oct 25, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Document DB-API required attributes and methods:

  • sqlite3.apilevel
  • sqlite3.paramstyle
  • sqlite3.threadsafety
  • sqlite3.Cursor.setinputsizes()
  • sqlite3.Cursor.setoutputsize()

https://bugs.python.org/issue45608

bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 25, 2021
erlend-aasland changed the title bpo-45608: Document missing sqlite3 DB-API attributes bpo-45608: Document missing sqlite3 DB-API attributes and methods Oct 25, 2021
pfmoore approved these changes Oct 26, 2021
View reviewed changes

pfmoore left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Approved with just one minor nitpick.

Comment thread Doc/library/sqlite3.rst Outdated

erlend-aasland commented Oct 26, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

PTAL, @pfmoore. Thanks for reviewing!

I also pushed a small wording improvement in b087d3a

erlend-aasland commented Oct 26, 2021

Copy link
Copy Markdown
Contributor Author

Thanks, Paul! @malemburg, does this look good to you?

erlend-aasland mentioned this pull request Oct 26, 2021
Merged
ambv merged commit 88d8a1a into python:main Oct 28, 2021

miss-islington commented Oct 28, 2021

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 28, 2021
bpo-45608: Document missing sqlite3 DB-API attributes and methods (p…
13db640 
…ythonGH-29219)

(cherry picked from commit 88d8a1a)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

bedevere-bot commented Oct 28, 2021

Copy link
Copy Markdown

GH-29281 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 28, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 28, 2021
bpo-45608: Document missing sqlite3 DB-API attributes and methods (p…
9787ff2 
…ythonGH-29219)

(cherry picked from commit 88d8a1a)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

bedevere-bot commented Oct 28, 2021

Copy link
Copy Markdown

GH-29282 is a backport of this pull request to the 3.9 branch.

erlend-aasland deleted the sqlite-doc-dbapi branch October 28, 2021 19:37

erlend-aasland commented Oct 28, 2021

Copy link
Copy Markdown
Contributor Author

Thanks, Łukasz!

ambv pushed a commit that referenced this pull request Oct 28, 2021
bpo-45608: Document missing sqlite3 DB-API attributes and methods (G…
1d88b2b 
…H-29219) (GH-29281)

(cherry picked from commit 88d8a1a)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
ambv pushed a commit that referenced this pull request Oct 28, 2021
bpo-45608: Document missing sqlite3 DB-API attributes and methods (G…
020aa06 
…H-29219) (GH-29282)

(cherry picked from commit 88d8a1a)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
erlend-aasland mentioned this pull request May 16, 2022
Closed
erlend-aasland mentioned this pull request Jul 27, 2022
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pfmoore pfmoore approved these changes
berkerpeksag Awaiting requested review from berkerpeksag
malemburg Awaiting requested review from malemburg
willingc Awaiting requested review from willingc

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL