FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.9] bpo-45678: Add ``functools.singledispatchmethod`` tests (GH-29328) by miss-islington · Pull Request #29391 · python/cpython · GitHub

Repository navigation

[3.9] bpo-45678: Add functools.singledispatchmethod tests (GH-29328) - #29391

Closed
miss-islington wants to merge 1 commit into
python:3.9from
miss-islington:backport-5a14929-3.9
Closed

miss-islington wants to merge 1 commit into
python:3.9from
miss-islington:backport-5a14929-3.9

Conversation

miss-islington commented Nov 3, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

(cherry picked from commit 5a14929)

Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com

https://bugs.python.org/issue45678

(cherry picked from commit 5a14929)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
bedevere-bot added the tests Tests in the Lib/test dir label Nov 3, 2021

Copy link
Copy Markdown
Contributor Author

@AlexWaygood and @ambv: Status check is done, and it's a success ✅ .

Copy link
Copy Markdown
Member

This is fun! @ambv, it appears that attempting to backport these new tests to 3.9 has uncovered a bug in the 3.9 branch, where staticmethod and classmethod singledispatchmethods don't properly wrap the docstrings or names of the target function. Would the best course of action be to:

  1. Abandon backporting this to 3.9?
  2. Apply a bugfix along with the new tests to 3.9, linking to the same BPO issue?
  3. Create a new BPO issue for a bugfix?

ambv commented Nov 3, 2021

Copy link
Copy Markdown
Contributor

Definitely worth fixing. Since you're not a committer (yet?), you won't be able to patch this PR so you can essentially recreate it as part of the fix. The fix can be part of this same BPO.

Copy link
Copy Markdown
Member

Definitely worth fixing. Since you're not a committer (yet?), you won't be able to patch this PR so you can essentially recreate it as part of the fix. The fix can be part of this same BPO.

Great, I'll get to work on a fix!

ambv commented Nov 4, 2021

Copy link
Copy Markdown
Contributor

Closing in favor of GH-29394.

ambv closed this Nov 4, 2021
miss-islington deleted the backport-5a14929-3.9 branch November 4, 2021 19:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL