Repository navigation
[3.9] bpo-45678: Fix singledispatchmethod classmethod/staticmethod bug - #29394
Merged
ambv merged 3 commits intoNov 4, 2021
Merged
ambv merged 3 commits into
ambv merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…od` bug This PR fixes a bug in the 3.9 branch where ``functools.singledispatchmethod`` did not properly wrap attributes such as ``__name__``, ``__doc__`` and ``__module__`` of the target method. It also backports tests already merged into the 3.11 and 3.10 branches in #python#29328 and python#29390.
Copy link
Copy Markdown
Member
Author
|
To test this bugfix, I added some additional tests that were not included in #29328 and #29390 (the previous PRs to the 3.10 & 3.11 branches). I'd like to "forward-port" these tests to 3.10 & 3.11 after this PR is merged (if it is accepted), before the BPO issue is closed. |
Sorry, something went wrong.
ambv
reviewed
Nov 4, 2021
Comment thread
Lib/functools.py
Outdated
Copy link
Copy Markdown
Contributor
|
Go ahead and "forward-port" the new tests, @AlexWaygood! |
Sorry, something went wrong.
AlexWaygood
added a commit
to AlexWaygood/cpython
that referenced
this pull request
Nov 4, 2021
In order to fix a bug in the 3.9 branch in python#29394, more tests were added to ``test_functools.py`` to ensure that ``singledispatchmethod`` still correctly wrapped a target method, even if the target method had already been wrapped by multiple other decorators. This PR brings the new tests into the 3.11 and 3.10 branches as well.
Copy link
Copy Markdown
Member
Author
Forward-port is here! #29412 😀 |
Sorry, something went wrong.
ambv
pushed a commit
that referenced
this pull request
Nov 5, 2021
In order to fix a bug in the 3.9 branch in #29394, more tests were added to ``test_functools.py`` to ensure that ``singledispatchmethod`` still correctly wrapped a target method, even if the target method had already been wrapped by multiple other decorators. This PR brings the new tests into the 3.11 and 3.10 branches as well.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 5, 2021
In order to fix a bug in the 3.9 branch in pythonGH-29394, more tests were added to ``test_functools.py`` to ensure that ``singledispatchmethod`` still correctly wrapped a target method, even if the target method had already been wrapped by multiple other decorators. This PR brings the new tests into the 3.11 and 3.10 branches as well. (cherry picked from commit 32f55d1) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
ambv
pushed a commit
that referenced
this pull request
Nov 5, 2021
In order to fix a bug in the 3.9 branch in GH-29394, more tests were added to ``test_functools.py`` to ensure that ``singledispatchmethod`` still correctly wrapped a target method, even if the target method had already been wrapped by multiple other decorators. This PR brings the new tests into the 3.11 and 3.10 branches as well. (cherry picked from commit 32f55d1) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the 3.9 branch where
functools.singledispatchmethod did not properly wrap attributes such as
__name__, __doc__ and __module__ of the target method. It also
backports tests already merged into the 3.11 and 3.10 branches in #29328 and
#29390.
https://bugs.python.org/issue45678