FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-28533: Remove asyncore, asynchat, smtpd modules by vstinner · Pull Request #29521 · python/cpython · GitHub

/ cpython Public

bpo-28533: Remove asyncore, asynchat, smtpd modules - #29521

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:remove_asyncore
Nov 15, 2021
ConversationCommits (1)ChecksFiles changed
Merged

bpo-28533: Remove asyncore, asynchat, smtpd modules#29521
vstinner merged 1 commit into
python:mainfrom
vstinner:remove_asyncore

Conversation

vstinner commented Nov 11, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Remove the asyncore and asynchat modules, deprecated in Python
3.6: use the asyncio module instead.

Remove the smtpd module, deprecated in Python 3.6: the aiosmtpd
module can be used instead, it is based on asyncio.

  • Remove asyncore, asynchat and smtpd documentation
  • Remove test_asyncore, test_asynchat and test_smtpd
  • Rename Lib/asynchat.py to Lib/test/support/_asynchat.py
  • Rename Lib/asyncore.py to Lib/test/support/_asyncore.py
  • Rename Lib/smtpd.py to Lib/test/support/_smtpd.py
  • Remove DeprecationWarning from private _asyncore, _asynchat and
    _smtpd modules
  • _smtpd: remove deprecated properties

https://bugs.python.org/issue28533

bpo-28533: Remove asyncore, asynchat, smtpd modules
1bf97aa 
Remove the asyncore and asynchat modules, deprecated in Python
3.6: use the asyncio module instead.

Remove the smtpd module, deprecated in Python 3.6: the aiosmtpd
module can be used instead, it is based on asyncio.

* Remove asyncore, asynchat and smtpd documentation
* Remove test_asyncore, test_asynchat and test_smtpd
* Rename Lib/asynchat.py to Lib/test/support/_asynchat.py
* Rename Lib/asyncore.py to Lib/test/support/_asyncore.py
* Rename Lib/smtpd.py to Lib/test/support/_smtpd.py
* Remove DeprecationWarning from private _asyncore, _asynchat and
  _smtpd modules
* _smtpd: remove deprecated properties
vstinner requested review from a team and vsajip as code owners November 11, 2021 12:10

vstinner commented Nov 11, 2021

Copy link
Copy Markdown
Member Author

A year ago @aeros worked on a patch: https://github.com/aeros/cpython/tree/remove-asycore-asynchat-smtpd

Kyle mentioned the PEP 594. I prefer to not mention it since this PEP is still a draft. IMO the deprecation and linked to bpo issues is enough to justify the removals.

cc @tiran

orsenthil approved these changes Nov 12, 2021
View reviewed changes

orsenthil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Thank you, @vstinner :)

gvanrossum approved these changes Nov 12, 2021
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It's time for these long-deprecated packages to leave.

tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 12, 2021

bedevere-bot commented Nov 12, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 1bf97aa 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 12, 2021
yan12125 mentioned this pull request Nov 15, 2021
Closed
13 tasks

vstinner commented Nov 15, 2021

Copy link
Copy Markdown
Member Author

I looked at buildbot failures:

  • AMD64 Windows10: unrelated, test_importlib failed. It looks like a Git clone issue. Not sure why it occurs on "PR" builds.
  • AMD64 Arch Linux Asan PR: unrelated, https://bugs.python.org/issue45797

vstinner merged commit 9bf2cbc into python:main Nov 15, 2021
vstinner deleted the remove_asyncore branch November 15, 2021 23:29

vstinner commented Nov 15, 2021

Copy link
Copy Markdown
Member Author

Merged. I prefer to merge such change early in the 3.11 devcycle, so we can revert it if it breaks too many projects.

Thanks for the reviews and approvals!

vstinner mentioned this pull request Nov 16, 2021
Closed
vstinner added a commit that referenced this pull request Dec 7, 2021
Revert "bpo-28533: Remove asyncore, asynchat, smtpd modules (GH-29521)…
cf7eaa4 
…" (GH-29951)

This reverts commit 9bf2cbc.
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
bpo-28533: Remove asyncore, asynchat, smtpd modules (pythonGH-29521)
20242e6 
Remove the asyncore and asynchat modules, deprecated in Python
3.6: use the asyncio module instead.

Remove the smtpd module, deprecated in Python 3.6: the aiosmtpd
module can be used instead, it is based on asyncio.

* Remove asyncore, asynchat and smtpd documentation
* Remove test_asyncore, test_asynchat and test_smtpd
* Rename Lib/asynchat.py to Lib/test/support/_asynchat.py
* Rename Lib/asyncore.py to Lib/test/support/_asyncore.py
* Rename Lib/smtpd.py to Lib/test/support/_smtpd.py
* Remove DeprecationWarning from private _asyncore, _asynchat and
  _smtpd modules
* _smtpd: remove deprecated properties
Mariatta mentioned this pull request Apr 11, 2022
Closed
arhadthedev mentioned this pull request Jun 7, 2022
Open

Karlson2k commented Jun 13, 2022

Copy link
Copy Markdown

In the meantime the suggested replacement supports Python versions up to 3.9. Python 3.10 and later is not supported.
There is no single commit in the past 14 months in the repo.
Python 3.11 will be released without working replacement. The suggested replacement is not compatible with 3.11.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vsajip vsajip approved these changes
warsaw warsaw approved these changes
orsenthil orsenthil approved these changes
tiran tiran approved these changes
gvanrossum gvanrossum approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL