FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "bpo-28533: Remove asyncore, asynchat, smtpd modules (GH-29521)" by vstinner · Pull Request #29951 · python/cpython · GitHub

/ cpython Public

Revert "bpo-28533: Remove asyncore, asynchat, smtpd modules (GH-29521)" - #29951

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:restore_asyncore
Dec 7, 2021
ConversationCommits (1)ChecksFiles changed
Merged

Revert "bpo-28533: Remove asyncore, asynchat, smtpd modules (GH-29521)"#29951
vstinner merged 1 commit into
python:mainfrom
vstinner:restore_asyncore

Conversation

vstinner commented Dec 7, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

vstinner requested review from a team and vsajip as code owners December 7, 2021 08:12
vstinner mentioned this pull request Dec 7, 2021
Closed

vstinner commented Dec 7, 2021

Copy link
Copy Markdown
Member Author

PR related to the SC decision: python/steering-council#86

warsaw approved these changes Dec 7, 2021
View reviewed changes
Comment thread Doc/library/socketserver.rst
particularly important for stream services where each client can potentially be
connected for a long time (if threads or subprocesses cannot be used). See
:mod:`asyncio` for another way to manage this.
:mod:`asyncore` for another way to manage this.

warsaw Dec 7, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can't you still recommend asyncio even with the revert?

vstinner Dec 7, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, it's possible, but I wanted to use a simple "git revert" command. Moreover, Miro wants to get it in 3.11.0a3, and Pablo suggests to merge the PR today, so I simply merged my PR.

hroncok commented Dec 7, 2021

Copy link
Copy Markdown
Contributor

@pablogsal Can we please include this in 3.11.0a3?

pablogsal commented Dec 7, 2021

Copy link
Copy Markdown
Member

@pablogsal Can we please include this in 3.11.0a3?

Yup, but let's make sure It's merged today. We have a bunch of release blockers anyway :(

vstinner merged commit cf7eaa4 into python:main Dec 7, 2021
vstinner deleted the restore_asyncore branch December 7, 2021 11:31
Mariatta mentioned this pull request Apr 11, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vsajip vsajip approved these changes
warsaw warsaw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL