bpo-45848: Delimitate when source lines can't be located in the parser error handling functions - #29626
Closed
pablogsal wants to merge 2 commits into
Closed
bpo-45848: Delimitate when source lines can't be located in the parser error handling functions#29626pablogsal wants to merge 2 commits into
pablogsal wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Running the test I added with the fix: test_encoding_cookie (test.test_peg_generator.test_c_parser.TestCPythonParserEdgeCases) ... ok ---------------------------------------------------------------------- Ran 1 test in 0.125s OK == Tests result: SUCCESS == Running the test without the fix: test test_peg_generator failed -- Traceback (most recent call last):
File "/private/tmp/cpymain/Lib/test/test_peg_generator/test_c_parser.py", line 512, in test_encoding_cookie
self.assert_python(
^^^^^^^^^^^^^^^^^^^
File "/private/tmp/cpymain/Lib/test/test_peg_generator/test_c_parser.py", line 507, in assert_python
self.assertNotIn(not_expected, output)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'Fatal Python error: Aborted' unexpectedly found in '\nAssertion failed: (p->tok->fp == NULL || p->tok->fp == stdin), function get_error_line, file Parser/pegen.c, line 408.\nFatal Python error: Aborted\n\nCurrent thread 0x000000010f006dc0 (most recent call first):\n <no Python frame>\n'
test_peg_generator failed (1 failure)
== Tests result: FAILURE ==
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue45848