| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
| error_line = PyErr_ProgramTextObject(p->tok->filename, (int) lineno); | ||
| else if (p->start_rule == Py_file_input) { | ||
| error_line = _PyErr_ProgramDecodedTextObject(p->tok->filename, | ||
| (int) lineno, p->tok->encoding); |
There was a problem hiding this comment.
👌🏻
Sorry, something went wrong.
|
Thanks @pablogsal for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
Sorry, something went wrong.
|
Sorry, @pablogsal and @ambv, I could not cleanly backport this to 3.10 due to a conflict. |
Sorry, something went wrong.
|
Sorry @pablogsal and @ambv, I had trouble checking out the 3.9 backport branch. |
Sorry, something went wrong.
…les (pythonGH-29646). (cherry picked from commit fdcc46d) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
|
GH-29661 is a backport of this pull request to the 3.10 branch. |
Sorry, something went wrong.
|
@pablogsal, backporting this to 3.9 is more involved as the parser is much simpler in this case, see: Lines 424 to 434 in e8d41ee There is no assert that failed in the original bug report, there is no get_error_line function, there is no fp_interactive, there is no TestCase under which you put the new test in. Let me know if you'd like me to still proceed with the backport. The current 3.11 crasher doesn't produce too terrible of a result under 3.9: ❯ python3.9 /tmp/crash.py
File "/tmp/crash.py", line 3
^
SyntaxError: unexpected EOF while parsing
|
Sorry, something went wrong.
Thanks @ambv ! I will give it a go but as this doesn't crash in 3.9 I'm ok to just leave as is, as in this way we can also avoid potential unintended side effects in 3.9. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
https://bugs.python.org/issue45848