bpo-46364: Use sockets only for stdin of asyncio on AIX by xopham · Pull Request #30596 · python/cpython · GitHub

The use of sockets for stdin of asyncio is restricted to AIX platform only to support reading from /dev/stdin using ascynio.create_subprocess_exec and asycio.create_subprocess_shell.

https://bugs.python.org/issue46364

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@xopham

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@asvetlov I am uncertain how to test this. Would you be able to point me in the right direction (code and test idea)?

It could be an async subprocess that reads 16 bytes of data from stdin and writes them back to stdout.
Use /dev/zero to don't interact with the real terminal in tests.
Check the returned data, should be 16 zeroes.
Skip the test on AIX.

The test may use unittest.IsolatedAsyncioTestCase and asyncio.create_subprocess_exec, streaming API is easier to use than protocol-based.
An example of IsolatedAsyncioTestCase is here: https://github.com/python/cpython/blob/main/Lib/test/test_asyncio/test_locks.py
tearDownModule is crucial for CPython self-test runner.

I have written some kind of test: tifv@6477c7e
On my Linux system it fails; until you add the changes in this pull request and then it succeeds.

Notes

I have conditioned the test to run on Linux only because I have little idea of what platforms are supposed to have /dev/stdin.
I didn't understand @asvetlov's suggestions about /dev/zero. Some existing tests in test_subprocess.py looked like a perfect fit instead, so I have copied and edited one of them.

@tifv I also tried around with the /dev/zero idea, but that does not create the reported error when reading from /dev/stdin does. Thanks for sharing the tests here 🙏 they seem good to me. Would be happy to join this and move forward. Has been at the back of my head for long enough 😉
@asvetlov can we merge the two separately or will they have to become one pull request? Happy for any input.

@tifv I have cherry-picked your commit.

@asvetlov I think this PR is complete and ready for review/merging.

@1st1 any feedback on this?

LGTM I'll schedule a buildbot run after you have fixed the news entry.

Signed-off-by: Christoph Hamsen <hamsen.christoph@posteo.de>

Subprocess opening /dev/stdin fails if it is a socketpair.

@kumaraditya303 fixed the news entry as requested. Let me know if anything else is needed.

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 0ac3aed 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

Seems okay.

Thanks @xopham for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

GH-98243 is a backport of this pull request to the 3.11 branch.

GH-98244 is a backport of this pull request to the 3.10 branch.

Signed-off-by: Christoph Hamsen <hamsen.christoph@posteo.de> Co-authored-by: July Tikhonov <july.tikh@gmail.com> (cherry picked from commit c9ed032) Co-authored-by: Christoph Hamsen <37963496+xopham@users.noreply.github.com>

* main: (38 commits) pythongh-98251: Allow venv to pass along PYTHON* variables to pip and ensurepip when they do not impact path resolution (pythonGH-98259) Bpo-41246: IOCP Proactor avoid callback code duplication (python#21399) bpo-46364: Use sockets for stdin of asyncio only on AIX (python#30596) pythongh-98178: syslog() is not thread-safe on macOS (python#98213) Mark all targets in `Doc/Makefile` as `PHONY` (pythonGH-98189) pythongh-97982: Factorize PyUnicode_Count() and unicode_count() code (python#98025) pythongh-96265: Formatting changes for faq/general (python#98129) tutorial: remove "with single quotes" (python#98204) pythongh-97669: Remove Tools/scripts/startuptime.py (python#98214) signalmodule.c uses _PyErr_WriteUnraisableMsg() (python#98217) pythongh-97669: Fix test_tools reference leak (python#98216) pythongh-97669: Create Tools/patchcheck/ directory (python#98186) pythongh-65046: Link to logging cookbook from asyncio docs (python#98207) Formatting fixes in contextlib docs (python#98111) pythongh-95276: Add callable entry to the glossary (python#95738) pythongh-96130: Rephrase use of "typecheck" verb for clarity (python#98144) Fix some incorrect indentation around the main switch (python#98177) pythongh-98172: Fix formatting in `except*` docs (python#98173) pythongh-97982: Remove asciilib_count() (python#98164) pythongh-95756: Free and NULL-out code caches when needed (pythonGH-98181) ...

* main: (37 commits) pythongh-98251: Allow venv to pass along PYTHON* variables to pip and ensurepip when they do not impact path resolution (pythonGH-98259) Bpo-41246: IOCP Proactor avoid callback code duplication (python#21399) bpo-46364: Use sockets for stdin of asyncio only on AIX (python#30596) pythongh-98178: syslog() is not thread-safe on macOS (python#98213) Mark all targets in `Doc/Makefile` as `PHONY` (pythonGH-98189) pythongh-97982: Factorize PyUnicode_Count() and unicode_count() code (python#98025) pythongh-96265: Formatting changes for faq/general (python#98129) tutorial: remove "with single quotes" (python#98204) pythongh-97669: Remove Tools/scripts/startuptime.py (python#98214) signalmodule.c uses _PyErr_WriteUnraisableMsg() (python#98217) pythongh-97669: Fix test_tools reference leak (python#98216) pythongh-97669: Create Tools/patchcheck/ directory (python#98186) pythongh-65046: Link to logging cookbook from asyncio docs (python#98207) Formatting fixes in contextlib docs (python#98111) pythongh-95276: Add callable entry to the glossary (python#95738) pythongh-96130: Rephrase use of "typecheck" verb for clarity (python#98144) Fix some incorrect indentation around the main switch (python#98177) pythongh-98172: Fix formatting in `except*` docs (python#98173) pythongh-97982: Remove asciilib_count() (python#98164) pythongh-95756: Free and NULL-out code caches when needed (pythonGH-98181) ...

the-knights-who-say-ni added the CLA not signed label Jan 14, 2022

bedevere-bot added the awaiting review label Jan 14, 2022

xopham force-pushed the fix-issue-46364 branch 2 times, most recently from ca4e918 to 3afa104 Compare January 14, 2022 13:00

xopham marked this pull request as ready for review January 14, 2022 14:45

xopham requested review from 1st1 and asvetlov as code owners January 14, 2022 14:45

the-knights-who-say-ni added CLA signed and removed CLA not signed labels Jan 15, 2022

xopham mannequin mentioned this pull request Apr 10, 2022

asyncio subprocess cannot read from /dev/stdin #90522

Closed

ezio-melotti removed the CLA signed label Jul 13, 2022

kumaraditya303 added topic-asyncio needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 13, 2022

kumaraditya303 approved these changes Oct 13, 2022

View reviewed changes

Comment thread Misc/NEWS.d/next/Library/2022-01-14-10-49-20.bpo-46364.SzhlU9.rst Outdated

bedevere-bot added awaiting core review and removed awaiting review labels Oct 13, 2022

kumaraditya303 added the type-bug An unexpected behavior, bug, or error label Oct 13, 2022

xopham and others added 2 commits October 13, 2022 13:35

bpo-46364: only use socket for stdin on AIX

a0a38c1

Signed-off-by: Christoph Hamsen <hamsen.christoph@posteo.de>

pythongh-90522 : add test

0ac3aed

Subprocess opening /dev/stdin fails if it is a socketpair.

xopham force-pushed the fix-issue-46364 branch from ef62e67 to 0ac3aed Compare October 13, 2022 11:35

xopham requested a review from gvanrossum as a code owner October 13, 2022 11:35

kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 13, 2022

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 13, 2022

gvanrossum approved these changes Oct 13, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels Oct 13, 2022

gvanrossum merged commit c9ed032 into python:main Oct 13, 2022

bedevere-bot removed the awaiting merge label Oct 13, 2022

bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 13, 2022

bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 13, 2022

bpo-46364: Use sockets only for stdin of asyncio on AIX by xopham · Pull Request #30596 · python/cpython · GitHub

Uh oh!

Uh oh!

bpo-46364: Use sockets only for stdin of asyncio on AIX - #30596

bpo-46364: Use sockets only for stdin of asyncio on AIX#30596gvanrossum merged 2 commits intopython:mainpython/cpython:mainfrom xopham:fix-issue-46364xopham/cpython:fix-issue-46364Copy head branch name to clipboard

Conversation

xopham commented Jan 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

the-knights-who-say-ni commented Jan 14, 2022

CLA Missing

Uh oh!

xopham commented Jan 14, 2022

Uh oh!

asvetlov commented Feb 2, 2022

Uh oh!

tifv commented Jul 18, 2022

Uh oh!

xopham commented Jul 29, 2022

Uh oh!

xopham commented Aug 12, 2022

Uh oh!

xopham commented Aug 12, 2022

Uh oh!

kumaraditya303 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xopham commented Oct 13, 2022

Uh oh!

bedevere-bot commented Oct 13, 2022

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Oct 13, 2022

Uh oh!

bedevere-bot commented Oct 13, 2022

Uh oh!

bedevere-bot commented Oct 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

bpo-46364: Use sockets only for stdin of asyncio on AIX#30596
gvanrossum merged 2 commits into
python:mainfrom
xopham:fix-issue-46364

xopham commented Jan 14, 2022 •
edited
Loading

kumaraditya303 left a comment •
edited
Loading