FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-98251: Allow venv to pass along PYTHON* variables to pip when they do not impact path resolution by zooba · Pull Request #98259 · python/cpython · GitHub

/ cpython Public

gh-98251: Allow venv to pass along PYTHON* variables to pip when they do not impact path resolution - #98259

Merged
zooba merged 2 commits into
python:mainfrom
zooba:gh-98251
Oct 14, 2022
ConversationCommits (2)ChecksFiles changed
Merged

gh-98251: Allow venv to pass along PYTHON* variables to pip when they do not impact path resolution#98259
zooba merged 2 commits into
python:mainfrom
zooba:gh-98251

Conversation

zooba commented Oct 14, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

zooba added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 14, 2022
zooba requested a review from vsajip as a code owner October 14, 2022 10:47
vsajip requested changes Oct 14, 2022
View reviewed changes

vsajip left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just the one minor suggestion, everything else seems fine.

Comment thread Misc/NEWS.d/next/Library/2022-10-14-11-46-31.gh-issue-98251.Uxc9al.rst Outdated

bedevere-bot commented Oct 14, 2022

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

Update Misc/NEWS.d/next/Library/2022-10-14-11-46-31.gh-issue-98251.Ux…
b5eece8 
…c9al.rst

Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>

zooba commented Oct 14, 2022

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

bedevere-bot commented Oct 14, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@vsajip: please review the changes made to this pull request.

bedevere-bot requested a review from vsajip October 14, 2022 15:19
zooba merged commit 2fe44f7 into python:main Oct 14, 2022

miss-islington commented Oct 14, 2022

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

zooba deleted the gh-98251 branch October 14, 2022 15:58
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 14, 2022
pythongh-98251: Allow venv to pass along PYTHON* variables to pip and…
009b8c4 
… ensurepip when they do not impact path resolution (pythonGH-98259)

(cherry picked from commit 2fe44f7)

Co-authored-by: Steve Dower <steve.dower@python.org>

bedevere-bot commented Oct 14, 2022

Copy link
Copy Markdown

GH-98262 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 14, 2022

bedevere-bot commented Oct 14, 2022

Copy link
Copy Markdown

GH-98263 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 14, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 14, 2022
pythongh-98251: Allow venv to pass along PYTHON* variables to pip and…
63a6905 
… ensurepip when they do not impact path resolution (pythonGH-98259)

(cherry picked from commit 2fe44f7)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this pull request Oct 14, 2022
gh-98251: Allow venv to pass along PYTHON* variables to pip and ensur…
c9da063 
…epip when they do not impact path resolution (GH-98259)

(cherry picked from commit 2fe44f7)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this pull request Oct 14, 2022
gh-98251: Allow venv to pass along PYTHON* variables to pip and ensur…
22ad9e5 
…epip when they do not impact path resolution (GH-98259)

(cherry picked from commit 2fe44f7)

Co-authored-by: Steve Dower <steve.dower@python.org>
carljm added a commit to carljm/cpython that referenced this pull request Oct 14, 2022
Merge branch 'main' into typewatch
6e53514 
* main: (38 commits)
  pythongh-98251: Allow venv to pass along PYTHON* variables to pip and ensurepip when they do not impact path resolution (pythonGH-98259)
  Bpo-41246: IOCP Proactor avoid callback code duplication (python#21399)
  bpo-46364: Use sockets for stdin of asyncio only on AIX (python#30596)
  pythongh-98178: syslog() is not thread-safe on macOS (python#98213)
  Mark all targets in `Doc/Makefile` as `PHONY` (pythonGH-98189)
  pythongh-97982: Factorize PyUnicode_Count() and unicode_count() code (python#98025)
  pythongh-96265: Formatting changes for faq/general (python#98129)
  tutorial: remove "with single quotes" (python#98204)
  pythongh-97669: Remove Tools/scripts/startuptime.py (python#98214)
  signalmodule.c uses _PyErr_WriteUnraisableMsg() (python#98217)
  pythongh-97669: Fix test_tools reference leak (python#98216)
  pythongh-97669: Create Tools/patchcheck/ directory (python#98186)
  pythongh-65046: Link to logging cookbook from asyncio docs (python#98207)
  Formatting fixes in contextlib docs (python#98111)
  pythongh-95276: Add callable entry to the glossary (python#95738)
  pythongh-96130: Rephrase use of "typecheck" verb for clarity (python#98144)
  Fix some incorrect indentation around the main switch (python#98177)
  pythongh-98172: Fix formatting in `except*` docs (python#98173)
  pythongh-97982: Remove asciilib_count() (python#98164)
  pythongh-95756: Free and NULL-out code caches when needed (pythonGH-98181)
  ...
carljm added a commit to carljm/cpython that referenced this pull request Oct 14, 2022
Merge branch 'main' into cached_property
0bb0c69 
* main: (37 commits)
  pythongh-98251: Allow venv to pass along PYTHON* variables to pip and ensurepip when they do not impact path resolution (pythonGH-98259)
  Bpo-41246: IOCP Proactor avoid callback code duplication (python#21399)
  bpo-46364: Use sockets for stdin of asyncio only on AIX (python#30596)
  pythongh-98178: syslog() is not thread-safe on macOS (python#98213)
  Mark all targets in `Doc/Makefile` as `PHONY` (pythonGH-98189)
  pythongh-97982: Factorize PyUnicode_Count() and unicode_count() code (python#98025)
  pythongh-96265: Formatting changes for faq/general (python#98129)
  tutorial: remove "with single quotes" (python#98204)
  pythongh-97669: Remove Tools/scripts/startuptime.py (python#98214)
  signalmodule.c uses _PyErr_WriteUnraisableMsg() (python#98217)
  pythongh-97669: Fix test_tools reference leak (python#98216)
  pythongh-97669: Create Tools/patchcheck/ directory (python#98186)
  pythongh-65046: Link to logging cookbook from asyncio docs (python#98207)
  Formatting fixes in contextlib docs (python#98111)
  pythongh-95276: Add callable entry to the glossary (python#95738)
  pythongh-96130: Rephrase use of "typecheck" verb for clarity (python#98144)
  Fix some incorrect indentation around the main switch (python#98177)
  pythongh-98172: Fix formatting in `except*` docs (python#98173)
  pythongh-97982: Remove asciilib_count() (python#98164)
  pythongh-95756: Free and NULL-out code caches when needed (pythonGH-98181)
  ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vsajip vsajip approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL