FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-46425: fix direct invokation of multiple test modules by sobolevn · Pull Request #30666 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-46425: fix direct invokation of multiple test modules - #30666

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
sobolevn:issue-46425-1
Jan 18, 2022
ConversationCommits (1)ChecksFiles changed
Merged

bpo-46425: fix direct invokation of multiple test modules#30666
serhiy-storchaka merged 1 commit into
python:mainfrom
sobolevn:issue-46425-1

Conversation

sobolevn commented Jan 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Refs #30641
CC @corona10 as my mentor.

https://bugs.python.org/issue46425

I am going to mark this as "needs backport" to 3.9 and 3.10, because this is a bugfix.

bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jan 18, 2022
serhiy-storchaka approved these changes Jan 18, 2022
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

serhiy-storchaka merged commit 1292aa6 into python:main Jan 18, 2022

miss-islington commented Jan 18, 2022

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington commented Jan 18, 2022

Copy link
Copy Markdown
Contributor

Sorry, @sobolevn and @serhiy-storchaka, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1292aa6db5bed889a3c87df443754fcae0177801 3.10

miss-islington commented Jan 18, 2022

Copy link
Copy Markdown
Contributor

Sorry @sobolevn and @serhiy-storchaka, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 1292aa6db5bed889a3c87df443754fcae0177801 3.9

sobolevn mentioned this pull request Jan 18, 2022
Merged

serhiy-storchaka commented Jan 19, 2022

Copy link
Copy Markdown
Member

@sobolevn, do you mind to create backports manually?

sobolevn commented Jan 19, 2022

Copy link
Copy Markdown
Member Author

Sure, will do today 👍

sobolevn mentioned this pull request Jan 19, 2022
Merged
sobolevn added a commit to sobolevn/cpython that referenced this pull request Jan 19, 2022
[3.10] bpo-46425: Fix direct invocation of multiple test modules (pyt…
a7a6daa 
…honGH-30666).

(cherry picked from commit 1292aa6)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

bedevere-bot commented Jan 19, 2022

Copy link
Copy Markdown

GH-30699 is a backport of this pull request to the 3.10 branch.

sobolevn added a commit to sobolevn/cpython that referenced this pull request Jan 19, 2022
[3.9] bpo-46425: Fix direct invocation of multiple test modules (pyth…
50b81a2 
…onGH-30666).

(cherry picked from commit 1292aa6)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

bedevere-bot commented Jan 19, 2022

Copy link
Copy Markdown

GH-30700 is a backport of this pull request to the 3.9 branch.

sobolevn commented Jan 19, 2022

Copy link
Copy Markdown
Member Author

Done:

corona10 pushed a commit that referenced this pull request Jan 20, 2022
[3.9] bpo-46425: Fix direct invocation of multiple test modules (GH-3…
8105dd2 
…0666) (GH-30700)
corona10 pushed a commit that referenced this pull request Jan 20, 2022
[3.10] bpo-46425: Fix direct invocation of multiple test modules (GH-…
a6a0885 
…30666) (GH-30699)
sobolevn mentioned this pull request Apr 16, 2022
Closed
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
[3.9] bpo-46425: Fix direct invocation of multiple test modules (pyth…
c8fae1c 
…onGH-30666) (pythonGH-30700)
serhiy-storchaka removed their assignment Jun 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL