Repository navigation
bpo-46425: fix direct invocation of test_sqlite3 - #30676
Merged
asvetlov merged 1 commit intoJan 22, 2022
Merged
asvetlov merged 1 commit into
asvetlov merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
erlend-aasland
approved these changes
Jan 18, 2022
erlend-aasland
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
lgtm, thanks!
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
This should not be backported. The sqlite3 test suite has changed a lot since 3.10 and 3.9. I don't think this would apply cleanly at all. IMO, I don't think it is worth backporting it. |
Sorry, something went wrong.
JelleZijlstra
approved these changes
Jan 19, 2022
kumaraditya303
approved these changes
Jan 19, 2022
asvetlov
approved these changes
Jan 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes ./python.exe Lib/test/test_sqlite3/... tests.
Without this change it fails:
» ./python.exe Lib/test/test_sqlite3/test_transactions.py Traceback (most recent call last): File "/Users/sobolev/Desktop/cpython/Lib/test/test_sqlite3/test_transactions.py", line 26, in <module> from .test_dbapi import memory_database ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ImportError: attempted relative import with no known parent packageRefs #30666
CC @corona10 as my mentor.
https://bugs.python.org/issue46425