Repository navigation
bpo-46539: Pass status of special typeforms to forward references - #30926
Merged
gvanrossum merged 6 commits intoJan 27, 2022
Merged
gvanrossum merged 6 commits into
gvanrossum merged 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Previously this didn't matter because there weren't any valid code paths that could trigger a type check with a special form, but after the bug fix for `Annotated` wrapping special forms it's now possible to annotate something like `Annotated['ClassVar[int]', (3, 4)]`. This change would also be needed for proposed future changes, such as allowing `ClassVar` and `Final` to nest each other in dataclasses.
JelleZijlstra
self-requested a review
January 26, 2022 20:41
gvanrossum
reviewed
Jan 26, 2022
gvanrossum
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
(This is not a full review.)
Sorry, something went wrong.
Comment thread
Lib/typing.py
Outdated
JelleZijlstra
requested changes
Jan 27, 2022
Comment thread
Misc/NEWS.d/next/Library/2022-01-26-20-36-30.bpo-46539.23iW1d.rst
Outdated
Comment thread
Lib/typing.py
Outdated
Comment thread
Lib/test/test_typing.py
JelleZijlstra
approved these changes
Jan 27, 2022
gvanrossum
reviewed
Jan 27, 2022
gvanrossum
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Okay, looks good. Taking into account the recent discussions of backports for typing.py, should this be backported?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I think it should be, this one is even more clearly a bugfix (and frankly, not that likely to appear in practice). |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @GBeauregard for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @GBeauregard for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 27, 2022
…thonGH-30926) Previously this didn't matter because there weren't any valid code paths that could trigger a type check with a special form, but after the bug fix for `Annotated` wrapping special forms it's now possible to annotate something like `Annotated['ClassVar[int]', (3, 4)]`. This change would also be needed for proposed future changes, such as allowing `ClassVar` and `Final` to nest each other in dataclasses. (cherry picked from commit ced5005) Co-authored-by: Gregory Beauregard <greg@greg.red>
Copy link
Copy Markdown
|
GH-30946 is a backport of this pull request to the 3.9 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 27, 2022
…thonGH-30926) Previously this didn't matter because there weren't any valid code paths that could trigger a type check with a special form, but after the bug fix for `Annotated` wrapping special forms it's now possible to annotate something like `Annotated['ClassVar[int]', (3, 4)]`. This change would also be needed for proposed future changes, such as allowing `ClassVar` and `Final` to nest each other in dataclasses. (cherry picked from commit ced5005) Co-authored-by: Gregory Beauregard <greg@greg.red>
Copy link
Copy Markdown
|
GH-30947 is a backport of this pull request to the 3.10 branch. |
Sorry, something went wrong.
miss-islington
added a commit
that referenced
this pull request
Jan 27, 2022
…-30926) Previously this didn't matter because there weren't any valid code paths that could trigger a type check with a special form, but after the bug fix for `Annotated` wrapping special forms it's now possible to annotate something like `Annotated['ClassVar[int]', (3, 4)]`. This change would also be needed for proposed future changes, such as allowing `ClassVar` and `Final` to nest each other in dataclasses. (cherry picked from commit ced5005) Co-authored-by: Gregory Beauregard <greg@greg.red>
miss-islington
added a commit
that referenced
this pull request
Jan 27, 2022
…-30926) Previously this didn't matter because there weren't any valid code paths that could trigger a type check with a special form, but after the bug fix for `Annotated` wrapping special forms it's now possible to annotate something like `Annotated['ClassVar[int]', (3, 4)]`. This change would also be needed for proposed future changes, such as allowing `ClassVar` and `Final` to nest each other in dataclasses. (cherry picked from commit ced5005) Co-authored-by: Gregory Beauregard <greg@greg.red>
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
…thonGH-30926) Previously this didn't matter because there weren't any valid code paths that could trigger a type check with a special form, but after the bug fix for `Annotated` wrapping special forms it's now possible to annotate something like `Annotated['ClassVar[int]', (3, 4)]`. This change would also be needed for proposed future changes, such as allowing `ClassVar` and `Final` to nest each other in dataclasses. (cherry picked from commit ced5005) Co-authored-by: Gregory Beauregard <greg@greg.red>
Daraan
added a commit
to Daraan/typing_extensions
that referenced
this pull request
Mar 26, 2025
JelleZijlstra
pushed a commit
to python/typing_extensions
that referenced
this pull request
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this didn't matter because there weren't any valid code paths
that could trigger a type conversion with a special form, but after the bug
fix for Annotated wrapping special forms it's now possible to annotate
something like Annotated['ClassVar[int]', (3, 4)]. This change would
also be needed for proposed future changes, such as allowing ClassVar
and Final to nest each other in dataclasses.
https://bugs.python.org/issue46539