Repository navigation
[3.10] bpo-46539: Pass status of special typeforms to forward references (GH-30926) - #30947
Merged
miss-islington merged 1 commit intoJan 27, 2022
Merged
miss-islington merged 1 commit into
miss-islington merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…thonGH-30926) Previously this didn't matter because there weren't any valid code paths that could trigger a type check with a special form, but after the bug fix for `Annotated` wrapping special forms it's now possible to annotate something like `Annotated['ClassVar[int]', (3, 4)]`. This change would also be needed for proposed future changes, such as allowing `ClassVar` and `Final` to nest each other in dataclasses. (cherry picked from commit ced5005) Co-authored-by: Gregory Beauregard <greg@greg.red>
miss-islington
requested review from
Fidget-Spinner and
gvanrossum
as code owners
January 27, 2022 03:18
Copy link
Copy Markdown
Contributor
Author
|
@GBeauregard and @gvanrossum: Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
Contributor
Author
|
@GBeauregard and @gvanrossum: Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
JelleZijlstra
approved these changes
Jan 27, 2022
Copy link
Copy Markdown
Contributor
Author
|
@GBeauregard and @gvanrossum: Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
gvanrossum
approved these changes
Jan 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this didn't matter because there weren't any valid code paths
that could trigger a type check with a special form, but after the bug
fix for Annotated wrapping special forms it's now possible to annotate
something like Annotated['ClassVar[int]', (3, 4)]. This change would
also be needed for proposed future changes, such as allowing ClassVar
and Final to nest each other in dataclasses.
(cherry picked from commit ced5005)
Co-authored-by: Gregory Beauregard greg@greg.red
https://bugs.python.org/issue46539