bpo-43224: Add TypeVarTuple.__name__ - #31954
Merged
JelleZijlstra merged 2 commits intoMar 18, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
I noticed that TypeVar and ParamSpec put their name in a __name__ attribute, but TypeVarTuple doesn't. Let's be consistent.
JelleZijlstra
requested review from
Fidget-Spinner and
gvanrossum
as code owners
March 17, 2022 04:11
Copy link
Copy Markdown
Member
Author
|
cc @mrahtz. Skipping news because we never released the previous version. |
Sorry, something went wrong.
JelleZijlstra
commented
Mar 17, 2022
Comment thread
Lib/test/test_typing.py
| self.assertEqual(repr(Unpack[tuple[Unpack[Ts]]]), '*tuple[*Ts]') | ||
| self.assertEqual(repr(Unpack[Tuple[Unpack[Ts]]]), '*typing.Tuple[*Ts]') | ||
|
|
||
| def test_repr_is_correct(self): |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Noticed this is the same as the function above.
Sorry, something went wrong.
serhiy-storchaka
approved these changes
Mar 17, 2022
Copy link
Copy Markdown
Contributor
|
Thanks Jelle! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that TypeVar and ParamSpec put their name in a __name__
attribute, but TypeVarTuple doesn't. Let's be consistent.
https://bugs.python.org/issue43224