FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add typing.TypeVarTuple, Unpack, assert_type by JelleZijlstra · Pull Request #7501 · python/typeshed · GitHub

/ typeshed Public

Add typing.TypeVarTuple, Unpack, assert_type - #7501

Merged
AlexWaygood merged 1 commit into
masterfrom
JelleZijlstra-patch-1
Mar 18, 2022
ConversationCommits (1)ChecksFiles changed
Merged

Add typing.TypeVarTuple, Unpack, assert_type#7501
AlexWaygood merged 1 commit into
masterfrom
JelleZijlstra-patch-1

Conversation

JelleZijlstra commented Mar 17, 2022

Copy link
Copy Markdown
Member

JelleZijlstra commented Mar 17, 2022
View reviewed changes
Comment thread stdlib/typing.pyi
Unpack: _SpecialForm

class TypeVarTuple:
__name__: str

JelleZijlstra Mar 17, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Anticipating python/cpython#31954.

AlexWaygood Mar 17, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should we wait until that's merged before merging this, or do you reckon we're good to go?

JelleZijlstra Mar 17, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Better to wait I think.

AlexWaygood Mar 17, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

(Converting this to a draft for now so it doesn't get accidentally merged in the meantime)

JelleZijlstra Mar 18, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I merged the CPython change

AlexWaygood Mar 18, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

And I merged this one :)

github-actions Bot commented Mar 17, 2022

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

AlexWaygood marked this pull request as draft March 17, 2022 05:51
JelleZijlstra marked this pull request as ready for review March 18, 2022 17:57
AlexWaygood merged commit 4d23919 into master Mar 18, 2022
AlexWaygood deleted the JelleZijlstra-patch-1 branch March 18, 2022 18:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL