FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-29660: traceback: Document that etype is ignored in some places. by Carreau · Pull Request #344 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-29660: traceback: Document that etype is ignored in some places. - #344

Merged
Mariatta merged 2 commits into
python:masterfrom
Carreau:doccument-deprecated-etype
Jun 1, 2017
ConversationCommits (2)ChecksFiles changed
Merged

bpo-29660: traceback: Document that etype is ignored in some places.#344
Mariatta merged 2 commits into
python:masterfrom
Carreau:doccument-deprecated-etype

Conversation

Carreau commented Feb 27, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

vadmium reviewed Feb 27, 2017
View reviewed changes
Comment thread Doc/library/traceback.rst Outdated

vadmium Feb 27, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

inferred (also repeated below)

Carreau Mar 2, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

fixed.

Comment thread Doc/library/traceback.rst Outdated

vadmium Feb 27, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Does not seem to be the case for “format_exception_only”

Carreau Mar 2, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

indeed, fixed.

Comment thread Doc/library/traceback.rst Outdated

vadmium Feb 27, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This does not seem ideal. It is less compatible with older Python versions. If it needs clarifying at all, perhaps a comment would be better?

Carreau Mar 2, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, sure.

vstinner changed the title bpo-29660: Document that etype is ignored in some places. bpo-29660: traceback: Document that etype is ignored in some places. Mar 2, 2017
vstinner added the docs Documentation in the Doc dir label Mar 2, 2017
Carreau force-pushed the doccument-deprecated-etype branch from 1069939 to b4727b6 Compare March 2, 2017 22:52

Carreau commented Mar 2, 2017

Copy link
Copy Markdown
Contributor Author

Thanks, sorry for the delay to fix. Comments should be addressed.

Mariatta reviewed May 17, 2017
View reviewed changes
Comment thread Doc/library/traceback.rst Outdated
print("*** print_tb:")
traceback.print_tb(exc_traceback, limit=1, file=sys.stdout)
print("*** print_exception:")
# exc_type below ignored on 3.5 and later

Mariatta May 17, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

is ignored on 3.5 and later

The same for below :)

Mariatta merged commit cdb89cd into python:master Jun 1, 2017

Mariatta commented Jun 1, 2017

Copy link
Copy Markdown
Member

Thanks @Carreau 🎉

Carreau deleted the doccument-deprecated-etype branch June 2, 2017 03:01
Carreau restored the doccument-deprecated-etype branch June 2, 2017 03:01
Carreau added a commit to Carreau/cpython that referenced this pull request Jun 2, 2017
[3.6] bpo-29660: traceback: Document that etype is ignored in some pl…
2104905 
…aces. (pythonGH-344)

(cherry picked from commit cdb89cd)
Carreau added a commit to Carreau/cpython that referenced this pull request Jun 2, 2017
[3.5] bpo-29660: traceback: Document that etype is ignored in some pl…
a1f1266 
…aces. (pythonGH-344)

(cherry picked from commit cdb89cd)
This was referenced Jun 2, 2017
Merged
Merged
Mariatta pushed a commit that referenced this pull request Jun 2, 2017
bpo-29660: traceback: Document that etype is ignored in some places. (G…
e417d12 
…H-344) (GH-1913)

(cherry picked from commit cdb89cd)
Mariatta pushed a commit that referenced this pull request Jun 2, 2017
bpo-29660: traceback: Document that etype is ignored in some places. (G…
cca3d4a 
…H-344) (GH-1914)

(cherry picked from commit cdb89cd)
Carreau deleted the doccument-deprecated-etype branch June 2, 2017 03:39
akruis pushed a commit to stackless-dev/stackless that referenced this pull request Nov 1, 2017
Issue python#28556: merge 5 more typing changes from upstream (python…
83ec302 
…#340, python#344, python#348, python#349, python#350)
akruis pushed a commit to stackless-dev/stackless that referenced this pull request Nov 1, 2017
Issue python#28556: merge 5 more typing changes from upstream (python…
043a8bc 
…#340, python#344, python#348, python#349, python#350) (3.5->3.6)
akruis pushed a commit to stackless-dev/stackless that referenced this pull request Nov 1, 2017
Issue python#28556: merge 5 more typing changes from upstream (python…
52f2959 
…#340, python#344, python#348, python#349, python#350) (3.6->3.7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vadmium vadmium left review comments
Mariatta Mariatta approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL