Repository navigation
Properly link against functions introduced in macOS 10.12 - #350
maxbelanger wants to merge 1 commit into
Conversation
Sorry, something went wrong.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:
Thanks again to your contribution and we look forward to looking at it! |
Sorry, something went wrong.
|
Please open an issue on bugs.python.org for this. But, note that in general, we do not claim to support building Python for an older OS X version with a newer SDK using weak links. |
Sorry, something went wrong.
|
Hey Ned, this is following up on http://bugs.python.org/issue27596. I took a closer look at the changes made in http://bugs.python.org/issue29057 but we don't think they solve the fundamental issue for our scenario (we deploy on 10.6-10.12 using the latest SDK, as Apple recommends), particularly when using Python 3. |
Sorry, something went wrong.
Bumps [pytest-asyncio](https://github.com/pytest-dev/pytest-asyncio) from 0.12.0 to 0.14.0. - [Release notes](https://github.com/pytest-dev/pytest-asyncio/releases) - [Commits](pytest-dev/pytest-asyncio@v0.12.0...v0.14.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Codification commit python#3 in post-c4 codification batch per supervisor 16:05:15Z dispatch. Anchors librarian 06:16Z (handle-namespace recurring per-cycle observation) + pythia python#350 (cross-project collision queue) + python#351 (per-cycle prediction confirmed by repeated fixup workarounds at 07:12Z, 08:10Z, 09:11Z, 10:12Z, 11:13Z, 12:50:32Z, 13:52:13Z, 14:53:48Z). Documents: - Cross-project handle collision class (multiple Phoenix-style teams on same OS user share role names like 'scribe', 'medic') - Proximate driver: nbs-sidecar-restart line 153 handle-strip collapses compound handles like supervisor-vib -> supervisor, erasing project distinctness when project name follows role - Current operational workaround: --root=PATH filter on every fixup call - Proposed one-line fix: add SC_ROOT to dedup key so cross-project sidecars stay separate by default (lines 167 + 169 area in script) The fix is local to nbs-sidecar-restart and does not require coordination with nbs-sidecar itself. --root=PATH becomes an additional filter rather than the only protection. Doc-only commit; not modifying nbs-sidecar-restart in this Phoenix repo (out of phoenix tree). Implementation deferred to whoever ships the script change.
macOS Sierra/10.12 introduced new functions that are problematic to link against (i.e. getentropy, clock_gettime, etc) because autoconf detecting their presence isn't sufficient to guarantee they will be available downlevel. Building Python using Xcode 8 and the macOS 10.12 SDK and following Apple's recommended practices (see https://developer.apple.com/library/content/documentation/DeveloperTools/Conceptual/cross_development/Configuring/configuring.html), to set MACOSX_DEPLOYMENT_TARGET to the minimum version to be supported (e.g. 10.8) will result in these functions being weakly linked. While testing on macOS 10.12 works properly, running Python on an older (yet declared supported) version will trigger a crash when the symbol is used, as the code doesn't appear to support the symbol being weakly defined (who would). Essentially, AC_CHECK_FUNCS is not sufficient for these functions on macOS, so we need to do extra work.
This patch alters configure not to check when building for Darwin and MACOSX_DEPLOYMENT_TARGET is defined to a version below 10.12, allowing proper down-level support.