FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-32411: IDLE: Remove line number sort in browser.py by csabella · Pull Request #5011 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-32411: IDLE: Remove line number sort in browser.py - #5011

Merged
terryjreedy merged 3 commits into
python:masterfrom
csabella:bpo32411
Jun 1, 2019
ConversationCommits (3)ChecksFiles changed
Merged

bpo-32411: IDLE: Remove line number sort in browser.py#5011
terryjreedy merged 3 commits into
python:masterfrom
csabella:bpo32411

Conversation

csabella commented Dec 25, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Since the input dictionary is created in line number and dictionaries are guaranteed to be in insertion order, the sort is no longer needed.

https://bugs.python.org/issue32411

csabella mentioned this pull request May 20, 2018
Closed

terryjreedy commented May 20, 2018

Copy link
Copy Markdown
Member

ON HOLD, as explained on the issue.

terryjreedy self-assigned this May 20, 2018
terryjreedy added performance Performance or resource usage needs backport to 3.7 labels May 20, 2018
terryjreedy requested changes May 20, 2018
View reviewed changes

terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The requested 'change' is to wait for circumstances to change ;-).

python deleted a comment from bedevere-bot May 20, 2018

rhettinger commented Jun 1, 2019

Copy link
Copy Markdown
Contributor

LGTM.

terryjreedy changed the title bpo-32411: IDLE: Remove sorting by line number in browser.py bpo-32411: IDLE: Remove line number sort in browser.py Jun 1, 2019
terryjreedy merged commit 1a4d9ff into python:master Jun 1, 2019

bedevere-bot commented Jun 1, 2019

Copy link
Copy Markdown

@terryjreedy: Please replace # with GH- in the commit message next time. Thanks!

miss-islington commented Jun 1, 2019

Copy link
Copy Markdown
Contributor

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 1, 2019
bpo-32411: IDLE: Remove line number sort in browser.py (pythonGH-5011)
82db303 
Insertion in line order makes sorting keys by line order unneeded.
(cherry picked from commit 1a4d9ff)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>

bedevere-bot commented Jun 1, 2019

Copy link
Copy Markdown

GH-13732 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Jun 1, 2019
bpo-32411: IDLE: Remove line number sort in browser.py (GH-5011)
ac60d1a 
Insertion in line order makes sorting keys by line order unneeded.
(cherry picked from commit 1a4d9ff)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
csabella deleted the bpo32411 branch June 1, 2019 23:37

csabella commented Jun 1, 2019

Copy link
Copy Markdown
Contributor Author

@terryjreedy, thank you!

DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
bpo-32411: IDLE: Remove line number sort in browser.py (python#5011)
1d86d56 
Insertion in line order makes sorting keys by line order unneeded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

terryjreedy terryjreedy approved these changes

Assignees

terryjreedy

Labels

performance Performance or resource usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL