FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-33051: IDLE: Separate editor options from the general tab in config by csabella · Pull Request #6082 · python/cpython · GitHub

Repository navigation

bpo-33051: IDLE: Separate editor options from the general tab in config - #6082

Closed
csabella wants to merge 2 commits into
python:mainfrom
csabella:editortab
Closed

csabella wants to merge 2 commits into
python:mainfrom
csabella:editortab

Conversation

csabella commented Mar 11, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Split the 'Editor Preferences' section of the General tab in configdialog into its own tab.

https://bugs.python.org/issue33051

terryjreedy commented May 17, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

I am skimming through some of your open IDLE patches before quitting for the night. In particular, are there any that can/should be merged before 3.7.0c1 next Tuesday? This looks like a straightforward cut/paste with light editing. I still must look at dialog itself. If I like it, YES.

Copy link
Copy Markdown
Contributor Author

@terryjreedy I looked through the other open IDLE patches I have. Two of them have new tests for editor.py, so those would probably be too big to try to look at before Tuesday. I don't know if this is one you'd want to check before then - #5011.

csabella closed this Jun 4, 2018
csabella deleted the editortab branch June 4, 2018 17:24

csabella commented Jun 4, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Closing this was unintentional but I need to see if I can recreate the branch to reopen it.

Restored and rebased to master.

Copy link
Copy Markdown
Member

I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches

Copy link
Copy Markdown
Member

Closing as obsolete. init_validators was separately added and used on the existing GenPage. #26621 is a similar patch that separated windows preferences from Shell and Edit preferences. I did it after moving helplist to extensions tab and creating an ExtPage class. Moving indent spaces, #22954, completes the major changes we start around 3 years ago.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL