FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-33654: Support BufferedProtocol in set_protocol() and start_tls() by 1st1 · Pull Request #7130 · python/cpython · GitHub

/ cpython Public

bpo-33654: Support BufferedProtocol in set_protocol() and start_tls() - #7130

Merged
1st1 merged 9 commits into
python:masterfrom
1st1:fixbuf
May 28, 2018
ConversationCommits (9)ChecksFiles changed
Merged

bpo-33654: Support BufferedProtocol in set_protocol() and start_tls()#7130
1st1 merged 9 commits into
python:masterfrom
1st1:fixbuf

Conversation

1st1 commented May 26, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

1st1 self-assigned this May 26, 2018
1st1 requested a review from asvetlov May 26, 2018 17:10
asvetlov approved these changes May 26, 2018
View reviewed changes

asvetlov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

looks good

asvetlov commented May 26, 2018

Copy link
Copy Markdown
Contributor

hmm, windows tests are failing

1st1 commented May 26, 2018

Copy link
Copy Markdown
Member Author

Yes, i'll be looking into win issues before merging.

1st1 commented May 27, 2018

Copy link
Copy Markdown
Member Author

@asvetlov please take a look at the 0238da4 -- I think I fixed the windows issue

asvetlov commented May 28, 2018

Copy link
Copy Markdown
Contributor

Wow, nice.
Waiting for merge.

1st1 mentioned this pull request May 28, 2018
Closed
1st1 merged commit dbf1022 into python:master May 28, 2018

miss-islington commented May 28, 2018

Copy link
Copy Markdown
Contributor

Thanks @1st1 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

1st1 deleted the fixbuf branch May 28, 2018 18:31
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2018
bpo-33654: Support BufferedProtocol in set_protocol() and start_tls() (…
541b923 
…pythonGH-7130)

In this commit:

* Support BufferedProtocol in set_protocol() and start_tls()
* Fix proactor to cancel readers reliably
* Update tests to be compatible with OpenSSL 1.1.1
* Clarify BufferedProtocol docs
* Bump TLS tests timeouts to 60 seconds; eliminate possible race from start_serving
* Rewrite test_start_tls_server_1
(cherry picked from commit dbf1022)

Co-authored-by: Yury Selivanov <yury@magic.io>

bedevere-bot commented May 28, 2018

Copy link
Copy Markdown

GH-7164 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request May 28, 2018
bpo-33654: Support BufferedProtocol in set_protocol() and start_tls() (…
bc3a002 
…GH-7130)

In this commit:

* Support BufferedProtocol in set_protocol() and start_tls()
* Fix proactor to cancel readers reliably
* Update tests to be compatible with OpenSSL 1.1.1
* Clarify BufferedProtocol docs
* Bump TLS tests timeouts to 60 seconds; eliminate possible race from start_serving
* Rewrite test_start_tls_server_1
(cherry picked from commit dbf1022)

Co-authored-by: Yury Selivanov <yury@magic.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

asvetlov asvetlov approved these changes

Assignees

1st1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL