FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-32458: Increase TLS timeout in test_asyncio by vstinner · Pull Request #7157 · python/cpython · GitHub

/ cpython Public

bpo-32458: Increase TLS timeout in test_asyncio - #7157

Closed
vstinner wants to merge 2 commits into
python:masterfrom
vstinner:asyncio_tls
Closed

bpo-32458: Increase TLS timeout in test_asyncio#7157
vstinner wants to merge 2 commits into
python:masterfrom
vstinner:asyncio_tls

Conversation

vstinner commented May 28, 2018
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

test_asyncio: Increase test_start_tls_server_1() client timeout from
5 seconds to 60 seconds, and server timeout from 10 to 120 seconds.

The timeout is only used to check if the test hangs, but the 5
seconds limit is commonly reached on slow CIs like Travis CI and some
buildbots.

https://bugs.python.org/issue32458

test_asyncio: Increase test_start_tls_server_1() client timeout from
5 seconds to 60 seconds, and server timeout from 10 to 120 seconds.

The timeout is only used to check if the test hangs, but the 5
seconds limit is commonly reached on slow CIs like Travis CI and some
buildbots.

Copy link
Copy Markdown
Member Author

I tested manually my PR on my laptop and I failed to make the test fail again. I opened 4 terminals to run commands in parallel:

(1) ./python -m test test_asyncio -m test_start_tls_server_1 -F
(2) ./python -m test -j16 -r
(3) ./python -m test -j16 -r
(4) ./python -m test -j16 -r

The system load was larger than 42.

Copy link
Copy Markdown
Member Author

Oh, the PR #5054 disabled SSL tests on the proactor event loop: my PR now also reenables these tests. Let's see if test_asyncio of my PR pass on AppVeyor ;-)

1st1 commented May 28, 2018

Copy link
Copy Markdown
Member

Sorry, need to close this as it's in direct conflict with #7130 that I'm about to merge :(

1st1 closed this May 28, 2018
vstinner deleted the asyncio_tls branch May 29, 2018 22:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL