FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-33876: Mention relevant pythonesque implementations by andresdelfino · Pull Request #7741 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-33876: Mention relevant pythonesque implementations - #7741

Closed
andresdelfino wants to merge 4 commits into
python:masterfrom
andresdelfino:mention-micropython
ConversationCommits (4)ChecksFiles changed
Closed

bpo-33876: Mention relevant pythonesque implementations#7741
andresdelfino wants to merge 4 commits into
python:masterfrom
andresdelfino:mention-micropython

Conversation

andresdelfino commented Jun 16, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

willingc commented Jun 16, 2018

Copy link
Copy Markdown
Contributor

Hi @andresdelfino, Thanks. If we are mentioning MicroPython, we should also mention CircuitPython as well.

willingc reviewed Jun 16, 2018
View reviewed changes

willingc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good. Let's add CircuitPython too.

andresdelfino commented Jun 16, 2018

Copy link
Copy Markdown
Contributor Author

CircuitPython added! I believe I have highlighted the main differences right. Wasn't sure about the URL, but https://learn.adafruit.com/welcome-to-circuitpython/what-is-circuitpython looked somewhat weird. The GitHub repository seemed better.

willingc approved these changes Jun 16, 2018
View reviewed changes
Comment thread Doc/reference/introduction.rst Outdated

CircuitPython
A MicroPython fork targeted towards students and beginners, with a strong
focus on Adafruit boards. For more information, see `the CircuitPython

willingc Jun 16, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @andresdelfino. All of Adafruit's boards are open-hardware which would be good to mention. Perhaps "...on Adafruit's open-hardware boards.

andresdelfino Jun 16, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done :)

willingc approved these changes Jun 16, 2018
View reviewed changes

willingc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @andresdelfino. I'll leave this open for another day for others to comment, but this looks good to me. Thanks for the helpful docs work that you are doing 👍

andresdelfino commented Jun 16, 2018

Copy link
Copy Markdown
Contributor Author

Please do not merge, see issue.

andresdelfino changed the title bpo-33876: Mention the MicroPython implementation in Introduction bpo-33876: Mention relevant pythonesque implementations Jun 18, 2018

Mariatta commented Jun 22, 2018

Copy link
Copy Markdown
Member

Thanks for the PR, but as I mentioned in bpo, I just don't think this list is needed in our documentation.

Mariatta closed this Jun 22, 2018
andresdelfino mentioned this pull request Jun 25, 2018
Closed
andresdelfino deleted the mention-micropython branch June 25, 2018 23:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

willingc willingc approved these changes

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL