bpo-34419: selectmodule.c does not compile on HP-UX due to bpo-31938 - #8796
Merged
taleinat merged 1 commit intoAug 17, 2018
Merged
bpo-34419: selectmodule.c does not compile on HP-UX due to bpo-31938#8796taleinat merged 1 commit into
taleinat merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
If absolutely necessary, I can add #ifndef __hpux. |
Sorry, something went wrong.
Comment thread
Misc/NEWS.d/next/Library/2018-08-17-11-40-54.bpo-34419.s0hzX3.rst
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I think this is just a cleanup after bpo-31938, so we can skip adding a NEWS entry.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
@berkerpeksag Done, file dropped.
Sorry, something went wrong.
Fix compile errors reported by HP aCC by changing oversights from 6dc57e2 which do not cause trouble on clang or GCC. Patch by Michael Osipov.
taleinat
approved these changes
Aug 17, 2018
taleinat
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This fixes two obvious bugs. Good catches in both cases!
LGTM
Sorry, something went wrong.
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Aug 19, 2018
* master: (107 commits) bpo-22057: Clarify eval() documentation (pythonGH-8812) bpo-34318: Convert deprecation warnings to errors in assertRaises() etc. (pythonGH-8623) bpo-22602: Raise an exception in the UTF-7 decoder for ill-formed sequences starting with "+". (pythonGH-8741) bpo-34415: Updated logging.Formatter docstring. (pythonGH-8811) bpo-34432: doc Mention complex and decimal.Decimal on str.format not about locales (pythonGH-8808) bpo-34381: refer to 'Running & Writing Tests' in README.rst (pythonGH-8797) Improve error message when mock.assert_has_calls fails (pythonGH-8205) Warn not to set SIGPIPE to SIG_DFL (python#6773) bpo-34419: selectmodule.c does not compile on HP-UX due to bpo-31938 (pythonGH-8796) bpo-34418: Fix HTTPErrorProcessor documentation (pythonGH-8793) bpo-34391: Fix ftplib test for TLS 1.3 (pythonGH-8787) bpo-34217: Use lowercase for windows headers (pythonGH-8472) bpo-34395: Fix memory leaks caused by incautious usage of PyMem_Resize(). (pythonGH-8756) bpo-34405: Updated to OpenSSL 1.1.0i for Windows builds. (pythonGH-8775) bpo-34384: Fix os.readlink() on Windows (pythonGH-8740) closes bpo-34400: Fix undefined behavior in parsetok(). (pythonGH-4439) bpo-34399: 2048 bits RSA keys and DH params (python#8762) Make regular expressions in test_tasks.py raw strings. (pythonGH-8759) smtplib documentation fixes (pythonGH-8708) Fix misindented yaml in logging how to example (pythonGH-8604) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix compile errors reported by HP aCC by changing oversights from 6dc57e2
which do not cause trouble on clang or GCC.
Patch by Michael Osipov.
Please see for a detailed description the bug report.
https://bugs.python.org/issue34419