FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-34432: doc Mention complex and decimal.Decimal on str.format note… by andresdelfino · Pull Request #8808 · python/cpython · GitHub

/ cpython Public

bpo-34432: doc Mention complex and decimal.Decimal on str.format note… - #8808

Merged
ericvsmith merged 2 commits into
python:masterfrom
andresdelfino:str.format-locale
Aug 18, 2018
ConversationCommits (2)ChecksFiles changed
Merged

bpo-34432: doc Mention complex and decimal.Decimal on str.format note…#8808
ericvsmith merged 2 commits into
python:masterfrom
andresdelfino:str.format-locale

Conversation

andresdelfino commented Aug 18, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot added docs Documentation in the Doc dir awaiting review labels Aug 18, 2018
ericvsmith requested changes Aug 18, 2018
View reviewed changes

ericvsmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks good to me. Thanks in advance for the also making the unrelated change (see my comment).

Comment thread Doc/library/stdtypes.rst Outdated
temporary change affects other threads.
When formatting a number (:class:`int`, :class:`float`, :class:`complex`,
:class:`decimal.Decimal` and subclasses) with the ``n`` type
(ex: ``'{:n}'.format(1234)``), the function sets temporarily the

ericvsmith Aug 18, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

As long you're editing this, could you change "sets temporarily" to "temporarily sets"?

andresdelfino Aug 18, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sure!

bedevere-bot commented Aug 18, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

andresdelfino commented Aug 18, 2018

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

bedevere-bot commented Aug 18, 2018

Copy link
Copy Markdown

Thanks for making the requested changes!

@ericvsmith: please review the changes made to this pull request.

ericvsmith merged commit 93b5655 into python:master Aug 18, 2018

miss-islington commented Aug 18, 2018

Copy link
Copy Markdown
Contributor

Thanks @andresdelfino for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 18, 2018
bpo-34432: doc Mention complex and decimal.Decimal on str.format not …
aeb502a 
…about locales (pythonGH-8808)

(cherry picked from commit 93b5655)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>

bedevere-bot commented Aug 18, 2018

Copy link
Copy Markdown

GH-8809 is a backport of this pull request to the 3.7 branch.

bedevere-bot commented Aug 18, 2018

Copy link
Copy Markdown

GH-8810 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 18, 2018
bpo-34432: doc Mention complex and decimal.Decimal on str.format not …
9e82612 
…about locales (pythonGH-8808)

(cherry picked from commit 93b5655)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
andresdelfino deleted the str.format-locale branch August 18, 2018 17:45
ericvsmith pushed a commit that referenced this pull request Aug 18, 2018
bpo-34432: doc Mention complex and decimal.Decimal on str.format not …
fbd0a14 
…about locales (GH-8808) (GH-8810)

(cherry picked from commit 93b5655)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
ericvsmith pushed a commit that referenced this pull request Aug 18, 2018
bpo-34432: doc Mention complex and decimal.Decimal on str.format note…
0fd6f83 
… about locales (GH-8808) (GH-8809)

(cherry picked from commit 93b5655)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
carljm added a commit to carljm/cpython that referenced this pull request Aug 19, 2018
Merge branch 'master' into cached-property
977ece0 
* master: (107 commits)
  bpo-22057: Clarify eval() documentation (pythonGH-8812)
  bpo-34318: Convert deprecation warnings to errors in assertRaises() etc. (pythonGH-8623)
  bpo-22602: Raise an exception in the UTF-7 decoder for ill-formed sequences starting with "+". (pythonGH-8741)
  bpo-34415: Updated logging.Formatter docstring. (pythonGH-8811)
  bpo-34432: doc Mention complex and decimal.Decimal on str.format not about locales (pythonGH-8808)
  bpo-34381: refer to 'Running & Writing Tests' in README.rst (pythonGH-8797)
  Improve error message when mock.assert_has_calls fails (pythonGH-8205)
  Warn not to set SIGPIPE to SIG_DFL (python#6773)
  bpo-34419: selectmodule.c does not compile on HP-UX due to bpo-31938 (pythonGH-8796)
  bpo-34418: Fix HTTPErrorProcessor documentation (pythonGH-8793)
  bpo-34391: Fix ftplib test for TLS 1.3 (pythonGH-8787)
  bpo-34217: Use lowercase for windows headers (pythonGH-8472)
  bpo-34395: Fix memory leaks caused by incautious usage of PyMem_Resize(). (pythonGH-8756)
  bpo-34405: Updated to OpenSSL 1.1.0i for Windows builds. (pythonGH-8775)
  bpo-34384: Fix os.readlink() on Windows (pythonGH-8740)
  closes bpo-34400: Fix undefined behavior in parsetok(). (pythonGH-4439)
  bpo-34399: 2048 bits RSA keys and DH params (python#8762)
  Make regular expressions in test_tasks.py raw strings. (pythonGH-8759)
  smtplib documentation fixes (pythonGH-8708)
  Fix misindented yaml in logging how to example (pythonGH-8604)
  ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ericvsmith ericvsmith approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL