gh-91860: Add typing.dataclass_transform (PEP 681) - #91861
Merged
JelleZijlstra merged 3 commits intoApr 26, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copied from typing-extensions (python/typing#1054, python/typing#1120). Documentation is intentionally omitted, so we can focus on getting the runtime part in before the feature freeze.
JelleZijlstra
requested review from
Fidget-Spinner and
gvanrossum
as code owners
April 23, 2022 15:15
Fidget-Spinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Wow. I just read the PEP and this implementation for the first time. So I'll have some newbie concerns.
Sorry, something went wrong.
AlexWaygood
reviewed
Apr 24, 2022
AlexWaygood
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Implementation and tests look good, just a few comments on the docstring
Sorry, something went wrong.
Comment thread
Lib/typing.py
Outdated
Comment thread
Lib/typing.py
Outdated
Comment thread
Lib/typing.py
Copy link
Copy Markdown
Member
Author
|
Thanks @Fidget-Spinner and @AlexWaygood for the feedback, I just pushed some changes. |
Sorry, something went wrong.
AlexWaygood
approved these changes
Apr 24, 2022
AlexWaygood
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM! :)
Sorry, something went wrong.
AlexWaygood
reviewed
Apr 24, 2022
Comment thread
Lib/typing.py
Outdated
JelleZijlstra
added a commit
to JelleZijlstra/typeshed
that referenced
this pull request
Apr 26, 2022
AlexWaygood
pushed a commit
to python/typeshed
that referenced
this pull request
Apr 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied from typing-extensions (python/typing#1054, python/typing#1120).
Documentation is intentionally omitted, so we can focus on getting the
runtime part in before the feature freeze.
#91860