dataclass_transform: accept **kwargs, rename field_descriptors - #1120
Merged
JelleZijlstra merged 4 commits intoApr 16, 2022
Merged
dataclass_transform: accept **kwargs, rename field_descriptors#1120JelleZijlstra merged 4 commits into
JelleZijlstra merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
debonte
approved these changes
Apr 6, 2022
This was referenced May 19, 2022
JelleZijlstra
added a commit
to JelleZijlstra/cpython
that referenced
this pull request
Apr 23, 2022
Copied from typing-extensions (python/typing#1054, python/typing#1120). Documentation is intentionally omitted, so we can focus on getting the runtime part in before the feature freeze.
JelleZijlstra
added a commit
to python/cpython
that referenced
this pull request
Apr 26, 2022
Copied from typing-extensions (python/typing#1054, python/typing#1120). Documentation is intentionally omitted, so we can focus on getting the runtime part in before the feature freeze.
5 tasks
fthaler
added a commit
to GridTools/gt4py
that referenced
this pull request
May 17, 2022
Typing-extensions version 4.2 is required for the use of `field_specifiers` in `dataclass_transform` (see python/typing#1120).
havogt
pushed a commit
to havogt/gt4py
that referenced
this pull request
May 17, 2022
Typing-extensions version 4.2 is required for the use of `field_specifiers` in `dataclass_transform` (see python/typing#1120).
havogt
pushed a commit
to havogt/gt4py
that referenced
this pull request
May 17, 2022
Typing-extensions version 4.2 is required for the use of `field_specifiers` in `dataclass_transform` (see python/typing#1120).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @debonte @erictraut. This implements the field_descriptors -> field_specifiers rename that was changed in the PEP yesterday and the **kwargs idea I just shared. Just a draft for now to share what the idea would look like at runtime.