FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.7] bpo-42773: fix tests not being run on pushes (GH-24004) by miss-islington · Pull Request #92341 · python/cpython · GitHub

/ cpython Public

[3.7] bpo-42773: fix tests not being run on pushes (GH-24004) - #92341

Merged
ned-deily merged 1 commit into
python:3.7from
miss-islington:backport-4ac923f-3.7
May 6, 2022
ConversationCommits (1)ChecksFiles changed
Merged

[3.7] bpo-42773: fix tests not being run on pushes (GH-24004)#92341
ned-deily merged 1 commit into
python:3.7from
miss-islington:backport-4ac923f-3.7

Conversation

miss-islington commented May 5, 2022

Copy link
Copy Markdown
Contributor

There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns lains@riseup.net
(cherry picked from commit 4ac923f)

Co-authored-by: Filipe Laíns lains@riseup.net

bpo-42773: fix tests not being run on pushes (pythonGH-24004)
86dd591 
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <lains@riseup.net>
(cherry picked from commit 4ac923f)

Co-authored-by: Filipe Laíns <lains@riseup.net>
bedevere-bot mentioned this pull request May 5, 2022
Merged

miss-islington commented May 5, 2022

Copy link
Copy Markdown
Contributor Author

@FFY00: Status check is done, and it's a success ✅ .

miss-islington commented May 5, 2022

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

JelleZijlstra mentioned this pull request May 5, 2022
Merged

miss-islington commented May 5, 2022

Copy link
Copy Markdown
Contributor Author

@FFY00: Status check is done, and it's a success ✅ .

1 similar comment

miss-islington commented May 5, 2022

Copy link
Copy Markdown
Contributor Author

@FFY00: Status check is done, and it's a success ✅ .

miss-islington commented May 5, 2022

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

miss-islington commented May 5, 2022

Copy link
Copy Markdown
Contributor Author

@FFY00: Status check is done, and it's a success ✅ .

miss-islington commented May 5, 2022

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

miss-islington commented May 5, 2022

Copy link
Copy Markdown
Contributor Author

@FFY00: Status check is done, and it's a success ✅ .

miss-islington commented May 5, 2022

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

miss-islington commented May 5, 2022

Copy link
Copy Markdown
Contributor Author

@FFY00: Status check is done, and it's a success ✅ .

miss-islington commented May 5, 2022

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

1 similar comment

miss-islington commented May 5, 2022

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

ned-deily merged commit 5adef3d into python:3.7 May 6, 2022
miss-islington deleted the backport-4ac923f-3.7 branch May 6, 2022 17:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes

Assignees

ned-deily

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL