FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.7] gh-80254: Disallow recursive usage of cursors in sqlite3 converters by erlend-aasland · Pull Request #92334 · python/cpython · GitHub

/ cpython Public

[3.7] gh-80254: Disallow recursive usage of cursors in sqlite3 converters - #92334

Merged
ned-deily merged 4 commits into
python:3.7from
erlend-aasland:backport-sqlite-converter-segfault-3.7
May 23, 2022
Merged

[3.7] gh-80254: Disallow recursive usage of cursors in sqlite3 converters#92334
ned-deily merged 4 commits into
python:3.7from
erlend-aasland:backport-sqlite-converter-segfault-3.7

Conversation

Copy link
Copy Markdown
Contributor

(cherry picked from commit c908dc5)

Co-authored-by: Sergey Fedoseev fedoseev.sergey@gmail.com
Co-authored-by: Jelle Zijlstra jelle.zijlstra@gmail.com

erlend-aasland and others added 3 commits May 4, 2022 23:50
…` converters

(cherry picked from commit c908dc5)

Co-authored-by: Sergey Fedoseev <fedoseev.sergey@gmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
erlend-aasland added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed awaiting review labels May 5, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit d52fd31 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 5, 2022

erlend-aasland commented May 5, 2022
edited
Loading

Copy link
Copy Markdown
Contributor Author

CI cannot find merge base, and decides that this is not worthy running the tests. Buildbots seem to ignore this fact though, so I guess that it's fine if they are green.

UPDATE: a little bit too fast there; AMD64 FreeBSD Non-Debug is green, but it did not run. It failed before even compiling.

Copy link
Copy Markdown
Contributor Author

This buildbot run does not look good. Do you experience this often on the 3.7 branch, @ambv?

JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We're not allowed to merge until regular CI passes (the check is required). Code looks good to me but we'll have to figure out what's up with CI.

Copy link
Copy Markdown
Contributor Author

I think it is related to 4ac923f

Copy link
Copy Markdown
Contributor Author

See also GH-21806

Copy link
Copy Markdown
Contributor Author

I think backporting both GH-24004 and GH-21806 will fix it. Maybe not both are required, but I think both should be backported.

Copy link
Copy Markdown
Member

I think backporting both GH-24004 and GH-21806 will fix it. Maybe not both are required, but I think both should be backported.

Seems reasonable. I triggered #92341 and #92342, but I am not authorized to merge to the 3.7 branch.

Copy link
Copy Markdown
Contributor Author

Great! I'll pull in 3.7 when the backports land.

vstinner commented May 5, 2022

Copy link
Copy Markdown
Member

The 3.7 branch no longer accept bugfixes, only security fixes: https://devguide.python.org/#status-of-python-branches

Do you consider that this change fix a security issue?

Copy link
Copy Markdown
Member

Do you consider that this change fix a security issue?

Yes, see discussion here.

ned-deily merged commit 2a353b2 into python:3.7 May 23, 2022
erlend-aasland deleted the backport-sqlite-converter-segfault-3.7 branch May 23, 2022 22:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL