FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.7] bpo-40548: Fix "Check for source changes (pull_request)" GH Action job (GH-21806) by miss-islington · Pull Request #92342 · python/cpython · GitHub

/ cpython Public

[3.7] bpo-40548: Fix "Check for source changes (pull_request)" GH Action job (GH-21806) - #92342

Merged
ned-deily merged 4 commits into
python:3.7from
miss-islington:backport-eaa5517-3.7
Sep 2, 2022
Merged

[3.7] bpo-40548: Fix "Check for source changes (pull_request)" GH Action job (GH-21806)#92342
ned-deily merged 4 commits into
python:3.7from
miss-islington:backport-eaa5517-3.7

Conversation

Copy link
Copy Markdown
Contributor

On Git 2.28, "git diff master..." (3 dots) no longer works when
"fetch --depth=1" is used, whereas it works on Git 2.26.

Replace "..." (3 dots) with ".." (2 dots) in the "git diff" command
computing the list of modified files between the base branch and the
PR branch.
(cherry picked from commit eaa5517)

Co-authored-by: Victor Stinner vstinner@python.org

pythonGH-21806)

On Git 2.28, "git diff master..." (3 dots) no longer works when
"fetch --depth=1" is used, whereas it works on Git 2.26.

Replace "..." (3 dots) with ".." (2 dots) in the "git diff" command
computing the list of modified files between the base branch and the
PR branch.
(cherry picked from commit eaa5517)

Co-authored-by: Victor Stinner <vstinner@python.org>

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

vstinner commented May 5, 2022

Copy link
Copy Markdown
Member

Why do you need this backport today?

Copy link
Copy Markdown
Member

See #92334

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a failure ❌ .

1 similar comment

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a failure ❌ .

Copy link
Copy Markdown
Contributor

Do we still want to pursue this in the 3.7 branch?

ned-deily merged commit 9d58933 into python:3.7 Sep 2, 2022
miss-islington deleted the backport-eaa5517-3.7 branch September 2, 2022 03:28

Copy link
Copy Markdown
Member

Do we still want to pursue this in the 3.7 branch?

Sorry, this should have been merged earlier; it slipped off my radar. Thanks for the backport!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL