gh-91162: Implement splitting of *tuple[int, ...] over T, *Ts in typing.py - #93318
Closed
mrahtz wants to merge 4 commits into
Closed
gh-91162: Implement splitting of *tuple[int, ...] over T, *Ts in typing.py#93318mrahtz wants to merge 4 commits into
mrahtz wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
mrahtz
requested review from
Fidget-Spinner,
JelleZijlstra and
gvanrossum
as code owners
May 28, 2022 12:57
Copy link
Copy Markdown
Member
|
(I think this probably does need a news entry, FWIW, since it wasn't in beta 1, and I assume we'll be backporting.) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I've just realised; TODO @mrahtz What happens if there's more than one unpacked arbitrary-length tuple in the args list? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Thanks past me! Added a test for this situation. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Closing in favour of Serhiy's: #93330 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #91162, we decided that it should be valid to do
and that the result should be tuple[int, *tuple[int, ...]].
This PR does the first half of the work necessary to enable this: the changes necessary in typing.py. The second half will be the equivalent machinery in genericaliasobject.c, but I'll do that in a separate PR, since I guess different people will want to review it.