gh-91162: Support substitution of TypeVar with an unpacked variable-size tuple - #93330
Closed
serhiy-storchaka wants to merge 10 commits into
Closed
gh-91162: Support substitution of TypeVar with an unpacked variable-size tuple#93330serhiy-storchaka wants to merge 10 commits into
serhiy-storchaka wants to merge 10 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…able-size tuple For example: A[T, *Ts][*tuple[int, ...]] -> A[int, *tuple[int, ...]] A[*Ts, T][*tuple[int, ...]] -> A[*tuple[int, ...], int]
serhiy-storchaka
marked this pull request as ready for review
May 29, 2022 18:49
serhiy-storchaka
requested review from
Fidget-Spinner,
JelleZijlstra and
gvanrossum
as code owners
May 29, 2022 18:49
This was referenced May 30, 2022
JelleZijlstra
approved these changes
Jun 4, 2022
Comment thread
Objects/genericaliasobject.c
| if (arg) { | ||
| if (vartuplearg < nitems) { | ||
| Py_DECREF(arg); | ||
| Py_DECREF(fillarg); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This could use an assert(fillarg) to make sure it's not NULL.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Py_DECREF() makes sure that the argument is not NULL. The result is the same -- a crash.
Sorry, something went wrong.
… into typing-subst-unpacked-vat-tuple
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example:
A[T, *Ts][*tuple[int, ...]] -> A[int, *tuple[int, ...]]
A[*Ts, T][*tuple[int, ...]] -> A[*tuple[int, ...], int]
#91162