FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-92546: Move pprint benchmark into pyperformance by arhadthedev · Pull Request #94613 · python/cpython · GitHub

/ cpython Public

gh-92546: Move pprint benchmark into pyperformance - #94613

Merged
miss-islington merged 4 commits into
python:mainfrom
arhadthedev:move-pprint-benchmark
Jul 25, 2022
ConversationCommits (4)ChecksFiles changed
Merged

gh-92546: Move pprint benchmark into pyperformance#94613
miss-islington merged 4 commits into
python:mainfrom
arhadthedev:move-pprint-benchmark

Conversation

arhadthedev commented Jul 6, 2022 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

This PR couples with python/pyperformance#222 and supersedes #92560. Inspired by #93096 (comment).

Automerge-Triggered-By: GH:ericsnowcurrently

arhadthedev mentioned this pull request Jul 6, 2022
Closed
This was referenced Jul 6, 2022
Merged
Open
kj7rrv mentioned this pull request Jul 6, 2022
Closed
hauntsaninja approved these changes Jul 8, 2022
View reviewed changes

hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Had a nit, but looks good!

Comment thread Misc/NEWS.d/next/Library/2022-07-06-21-24-03.gh-issue-92546.s5Upkh.rst Outdated
Address Shantanu's review
f7bc339 
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
arhadthedev closed this Jul 8, 2022
arhadthedev reopened this Jul 8, 2022

arhadthedev commented Jul 8, 2022

Copy link
Copy Markdown
Member Author

Restart tests because test.test_ssl.SimpleBackgroundTests.test_get_server_certificate_timeout timeout failure seems unrelated.

arhadthedev commented Jul 24, 2022

Copy link
Copy Markdown
Member Author

@ericsnowcurrently Could you look at this PR please? It removes the code fetched by python/pyperformance#222.

ericsnowcurrently approved these changes Jul 25, 2022
View reviewed changes

ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, aside from one small change.

Comment thread Misc/NEWS.d/next/Library/2022-07-06-21-24-03.gh-issue-92546.s5Upkh.rst Outdated

miss-islington commented Jul 25, 2022

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅ .

miss-islington merged commit c514094 into python:main Jul 25, 2022
arhadthedev deleted the move-pprint-benchmark branch July 25, 2022 18:32

ericsnowcurrently commented Jul 26, 2022

Copy link
Copy Markdown
Member

Thanks for working on this, @arhadthedev!

denballakh mentioned this pull request Oct 5, 2022
Closed
donbarbos mentioned this pull request Mar 12, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ericsnowcurrently ericsnowcurrently approved these changes
hauntsaninja hauntsaninja approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL