FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add a benchmark based on `python -m pprint` by arhadthedev · Pull Request #222 · python/pyperformance · GitHub

/ pyperformance Public

Add a benchmark based on python -m pprint - #222

Merged
ericsnowcurrently merged 9 commits into
python:mainfrom
arhadthedev:pprint
Jul 7, 2022
ConversationCommits (9)ChecksFiles changed
Merged

Add a benchmark based on python -m pprint#222
ericsnowcurrently merged 9 commits into
python:mainfrom
arhadthedev:pprint

Conversation

arhadthedev commented Jul 6, 2022

Copy link
Copy Markdown
Member
  1. The moved code measures performance so it should belong here.
  2. The relocation lifts off a question whether python -m pprint should have tests or not.

After merging, python/cpython#92546 needs to be closed.

This was referenced Jul 6, 2022
Closed
Closed

arhadthedev commented Jul 6, 2022

Copy link
Copy Markdown
Member Author

This creative PR is a receiving half of python/cpython#94613.

This was referenced Jul 6, 2022
Merged
Open
ericsnowcurrently changed the title Move a benchmark from python -m pprint Add a benchmark based on python -m pprint Jul 7, 2022
ericsnowcurrently requested changes Jul 7, 2022
View reviewed changes

ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for working on this, Oleg! I've left some comments for you to consider.

Comment thread pyperformance/data-files/benchmarks/bm_from_stdlib/pyproject.toml Outdated
Comment thread pyperformance/data-files/benchmarks/bm_from_stdlib/run_benchmark.py Outdated
Comment thread pyperformance/data-files/benchmarks/bm_from_stdlib/run_benchmark.py Outdated
Comment thread pyperformance/data-files/benchmarks/bm_from_stdlib/run_benchmark.py Outdated
Comment thread pyperformance/data-files/benchmarks/bm_from_stdlib/run_benchmark.py Outdated
Comment thread pyperformance/data-files/benchmarks/bm_from_stdlib/run_benchmark.py Outdated
Comment thread pyperformance/data-files/benchmarks/bm_from_stdlib/run_benchmark.py Outdated

arhadthedev commented Jul 7, 2022

Copy link
Copy Markdown
Member Author

@ericsnowcurrently Thank you for your thorough feedback, I've addressed everything.

In addition, I've also moved a class docstring into a file comment, and reworded it together with authorship. I hope I've made it right.

Also I've added hasattr-based conditional running of _safe_repr to not fail CI for pre-3.10 CPython.

What did you have in mind relative to stdlib benchmarks? Note that we already have a bunch of micro-benchmarks for various parts of the stdlib, in distinct benchmarks.

Initially I've thought that a benchmark should be big, like Lib/test/*.py test files.

ericsnowcurrently approved these changes Jul 7, 2022
View reviewed changes

ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the updates.

ericsnowcurrently merged commit 684eafe into python:main Jul 7, 2022
arhadthedev deleted the pprint branch July 8, 2022 03:12
miss-islington pushed a commit to python/cpython that referenced this pull request Jul 25, 2022
gh-92546: Move pprint benchmark into pyperformance (GH-94613)
c514094 
This PR couples with python/pyperformance#222 and supersedes #92560. Inspired by #93096 (comment).

Automerge-Triggered-By: GH:ericsnowcurrently
donbarbos mentioned this pull request Mar 12, 2025
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ericsnowcurrently ericsnowcurrently approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL