[3.10] gh-95010: Fix asyncio GenericWatcherTests.test_create_subprocess_fails_with_inactive_watcher (GH-95009) - #95093
Closed
miss-islington wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…s_fails_with_inactive_watcher (pythonGH-95009) The test was never run, because it was missing the TestCase class. The test failed because the wrong attribute was patched. (cherry picked from commit 834bd5d) Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Copy link
Copy Markdown
Contributor
Author
|
Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
Contributor
Author
|
Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@graingert and @serhiy-storchaka: Status check is done, and it's a success ❌ . |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@kumaraditya303 I need to edit this to get the tests to pass on the backport, but I can't push to this branch should I open a new PR? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Yes, you have to manually create a PR. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks I'll do that now |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was never run, because it was missing the TestCase class.
The test failed because the wrong attribute was patched.
(cherry picked from commit 834bd5d)
Co-authored-by: Thomas Grainger tagrain@gmail.com