FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-95010: fix asyncio GenericWatcherTests.test_create_subprocess_fails_with_inactive_wa… by graingert · Pull Request #95009 · python/cpython · GitHub

/ cpython Public

gh-95010: fix asyncio GenericWatcherTests.test_create_subprocess_fails_with_inactive_wa… - #95009

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
graingert:fix-generic-watcher-tests
Jul 21, 2022
ConversationCommits (1)ChecksFiles changed
Merged

gh-95010: fix asyncio GenericWatcherTests.test_create_subprocess_fails_with_inactive_wa…#95009
serhiy-storchaka merged 1 commit into
python:mainfrom
graingert:fix-generic-watcher-tests

Conversation

graingert commented Jul 19, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

fix asyncio GenericWatcherTests.test_create_subprocess_fails_with_inactive_watcher

the test was never run, because it was missing the TestCase class
the test failed because the wrong attribute was patched

bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jul 19, 2022
graingert changed the title fix GenericWatcherTests.test_create_subprocess_fails_with_inactive_wa… fix asyncio GenericWatcherTests.test_create_subprocess_fails_with_inactive_wa… Jul 19, 2022
graingert force-pushed the fix-generic-watcher-tests branch from 823b0c4 to 9877b92 Compare July 19, 2022 15:32
graingert changed the title fix asyncio GenericWatcherTests.test_create_subprocess_fails_with_inactive_wa… gh-95009: fix asyncio GenericWatcherTests.test_create_subprocess_fails_with_inactive_wa… Jul 19, 2022

graingert commented Jul 19, 2022

Copy link
Copy Markdown
Contributor Author

this is just a test change and doesn't need news

graingert changed the title gh-95009: fix asyncio GenericWatcherTests.test_create_subprocess_fails_with_inactive_wa… gh-95010: fix asyncio GenericWatcherTests.test_create_subprocess_fails_with_inactive_wa… Jul 19, 2022
pythongh-95010: fix asyncio GenericWatcherTests.test_create_subproces…
20b9bd0 
…s_fails_with_inactive_watcher

the test was never run, because it was missing the TestCase class
the test failed because the wrong attribute was patched
graingert force-pushed the fix-generic-watcher-tests branch from 4f47e21 to 20b9bd0 Compare July 19, 2022 15:50

graingert commented Jul 19, 2022

Copy link
Copy Markdown
Contributor Author

It's best to review this in side-by-side mode, because GenericWatcherTests needed to be indented: https://github.com/python/cpython/pull/95009/files?diff=split

graingert marked this pull request as ready for review July 19, 2022 15:52
graingert requested review from 1st1 and asvetlov as code owners July 19, 2022 15:52
graingert mentioned this pull request Jul 19, 2022
Merged
serhiy-storchaka approved these changes Jul 21, 2022
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

graingert commented Jul 21, 2022

Copy link
Copy Markdown
Contributor Author

This should probably be backported to 3.10 as it's needed to verify a bugfix

kumaraditya303 added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jul 21, 2022
serhiy-storchaka merged commit 834bd5d into python:main Jul 21, 2022

miss-islington commented Jul 21, 2022

Copy link
Copy Markdown
Contributor

Thanks @graingert for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

bedevere-bot commented Jul 21, 2022

Copy link
Copy Markdown

GH-95092 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed needs backport to 3.11 only security fixes needs backport to 3.10 only security fixes labels Jul 21, 2022

bedevere-bot commented Jul 21, 2022

Copy link
Copy Markdown

GH-95093 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 21, 2022
pythongh-95010: Fix asyncio GenericWatcherTests.test_create_subproces…
3b4ee85 
…s_fails_with_inactive_watcher (pythonGH-95009)

The test was never run, because it was missing the TestCase class.
The test failed because the wrong attribute was patched.
(cherry picked from commit 834bd5d)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 21, 2022
pythongh-95010: Fix asyncio GenericWatcherTests.test_create_subproces…
0bf111e 
…s_fails_with_inactive_watcher (pythonGH-95009)

The test was never run, because it was missing the TestCase class.
The test failed because the wrong attribute was patched.
(cherry picked from commit 834bd5d)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
graingert deleted the fix-generic-watcher-tests branch July 21, 2022 11:57
miss-islington added a commit that referenced this pull request Jul 21, 2022
gh-95010: Fix asyncio GenericWatcherTests.test_create_subprocess_fail…
d19b5d8 
…s_with_inactive_watcher (GH-95009)

The test was never run, because it was missing the TestCase class.
The test failed because the wrong attribute was patched.
(cherry picked from commit 834bd5d)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
graingert mentioned this pull request Jul 21, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes
1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL