[3.10] gh-95010: Fix asyncio GenericWatcherTests.test_create_subprocess_fail… - #95099
[3.10] gh-95010: Fix asyncio GenericWatcherTests.test_create_subprocess_fail…#95099graingert wants to merge 2 commits into
Conversation
Sorry, something went wrong.
…s_fails_with_inactive_watcher (pythonGH-95009) The test was never run, because it was missing the TestCase class. The test failed because the wrong attribute was patched. (cherry picked from commit 834bd5d) Co-authored-by: Thomas Grainger <tagrain@gmail.com>
There was a problem hiding this comment.
Why not just use self.loop.run_until_complete() as in other tests?
Sorry, something went wrong.
There was a problem hiding this comment.
the GenericWatcherTests don't have a self.loop, and SubprocessWatcherMixin (which sets self.loop) calls get_event_loop_policy().attach_loop and this test case is testing what happens when attach_loop isn't called
Sorry, something went wrong.
There was a problem hiding this comment.
Many classes set self.loop. For this test you can inherit from test_utils.TestCase and add
def setUp(self):
super().setUp()
self.loop = asyncio.new_event_loop()
self.set_event_loop(self.loop)
Sorry, something went wrong.
|
I think I'll try to hurdle this hurdle when backporting #94184 |
Sorry, something went wrong.
…s_with_inactive_watcher (GH-95009)
The test was never run, because it was missing the TestCase class.
The test failed because the wrong attribute was patched.
(cherry picked from commit 834bd5d)
Co-authored-by: Thomas Grainger tagrain@gmail.com