FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Docs: Fix backtick errors found by sphinx-lint by hugovk · Pull Request #97998 · python/cpython · GitHub

/ cpython Public

Docs: Fix backtick errors found by sphinx-lint - #97998

Merged
ambv merged 4 commits into
python:mainfrom
hugovk:fix-sphinx-lint
Oct 7, 2022
ConversationCommits (4)ChecksFiles changed
Merged

Docs: Fix backtick errors found by sphinx-lint#97998
ambv merged 4 commits into
python:mainfrom
hugovk:fix-sphinx-lint

Conversation

hugovk commented Oct 6, 2022

Copy link
Copy Markdown
Member

No description provided.

hugovk added skip issue skip news docs Documentation in the Doc dir labels Oct 6, 2022
ezio-melotti reviewed Oct 6, 2022
View reviewed changes
Comment thread Doc/howto/logging.rst Outdated
Comment thread Doc/library/concurrent.futures.rst Outdated
Comment thread Doc/library/concurrent.futures.rst Outdated
Comment thread Doc/library/dis.rst Outdated
Comment thread Doc/library/hashlib.rst Outdated
hugovk commented Oct 6, 2022
View reviewed changes

hugovk left a comment •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Use ... for True/False/None

Edit: oops, this was meant to be the review commit message! The buttons are next to each other... Will try again!

hugovk and others added 2 commits October 7, 2022 02:07
Use ... for True/False/None
96f26d4 
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Make formatting consistent
192432d 
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
ambv merged commit fa2d43e into python:main Oct 7, 2022
hugovk deleted the fix-sphinx-lint branch October 7, 2022 01:02

CAM-Gerlach commented Oct 7, 2022

Copy link
Copy Markdown
Member

I can manually backport the changes (minus the Sphinx-lint for 3.10) since they do fix genuine defects and will avoid future merge conflicts when backporting other PRs, and can follow up later with a PR bumping 3.11 and 3.12 to the latest version of Sphinx-Lint (0.6.5, at this writing, which fixes an additional false positive found in the CPython docs that this PR worked around).

ezio-melotti commented Oct 7, 2022

Copy link
Copy Markdown
Member

SGTM. Coordinate on Discord/IRL so that we don't step on each other's toes, and feel free to @mention me on issues/PRs.

CAM-Gerlach commented Oct 7, 2022

Copy link
Copy Markdown
Member

Yup, talked to @hugovk about it—was sitting right next to him IRL yesterday and made sure we didn't duplicate each others' work on the various issues that came up 👍

carljm added a commit to carljm/cpython that referenced this pull request Oct 8, 2022
Merge branch 'main' into typewatch
0de5aff 
* main:
  pythongh-86298: Ensure that __loader__ and __spec__.loader agree in warnings.warn_explicit() (pythonGH-97803)
  pythongh-82874: Convert remaining importlib format uses to f-str. (python#98005)
  Docs: Fix backtick errors found by sphinx-lint (python#97998)
  pythongh-97850: Remove deprecated functions from `importlib.utils` (python#97898)
  Remove extra spaces in custom openSSL documentation. (python#93568)
  pythonGH-90985: Revert  "Deprecate passing a message into cancel()" (python#97999)
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
Docs: Fix backtick errors found by sphinx-lint (python#97998)
bd03a34 
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
CAM-Gerlach mentioned this pull request Oct 17, 2022
Merged
CAM-Gerlach pushed a commit to CAM-Gerlach/cpython that referenced this pull request Oct 17, 2022
[3.11] Docs: Fix backtick errors found by sphinx-lint (pythonGH-97998)
a6ea2cc 
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>.
(cherry picked from commit fa2d43e)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
CAM-Gerlach mentioned this pull request Oct 17, 2022
Merged

bedevere-bot commented Oct 17, 2022

Copy link
Copy Markdown

GH-98371 is a backport of this pull request to the 3.11 branch.

CAM-Gerlach pushed a commit to CAM-Gerlach/cpython that referenced this pull request Oct 17, 2022
[3.10] Docs: Fix backtick errors found by sphinx-lint (pythonGH-97998)
b12e449 
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>.
(cherry picked from commit fa2d43e)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
CAM-Gerlach mentioned this pull request Oct 17, 2022
Merged

bedevere-bot commented Oct 17, 2022

Copy link
Copy Markdown

GH-98373 is a backport of this pull request to the 3.10 branch.

ezio-melotti pushed a commit that referenced this pull request Oct 17, 2022
[3.11] Docs: Fix backtick errors found by sphinx-lint (GH-97998) (#98371
ea19c28 
)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>.
(cherry picked from commit fa2d43e)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
ezio-melotti pushed a commit that referenced this pull request Oct 17, 2022
[3.10] Docs: Fix backtick errors found by sphinx-lint (GH-97998) (#98373
b2db1c2 
)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>.
(cherry picked from commit fa2d43e)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
[3.11] Docs: Fix backtick errors found by sphinx-lint (GH-97998) (#98371
f1ca2f6 
)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>.
(cherry picked from commit fa2d43e)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ezio-melotti ezio-melotti left review comments

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL