gh-82874: Convert remaining importlib format uses to f-str. - #98005
Merged
gpshead merged 2 commits intoOct 7, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
gpshead
marked this pull request as ready for review
October 7, 2022 00:41
gpshead
commented
Oct 7, 2022
Comment thread
Lib/importlib/__init__.py
Outdated
ericvsmith
requested changes
Oct 7, 2022
ericvsmith
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Other than the one error, looks okay to me.
Sorry, something went wrong.
Comment thread
Lib/importlib/__init__.py
Outdated
Copy link
Copy Markdown
|
When you're done making the requested changes, leave the comment: I have made the requested changes; please review again. |
Sorry, something went wrong.
ericvsmith
approved these changes
Oct 7, 2022
brettcannon
approved these changes
Oct 7, 2022
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Oct 8, 2022
* main: pythongh-86298: Ensure that __loader__ and __spec__.loader agree in warnings.warn_explicit() (pythonGH-97803) pythongh-82874: Convert remaining importlib format uses to f-str. (python#98005) Docs: Fix backtick errors found by sphinx-lint (python#97998) pythongh-97850: Remove deprecated functions from `importlib.utils` (python#97898) Remove extra spaces in custom openSSL documentation. (python#93568) pythonGH-90985: Revert "Deprecate passing a message into cancel()" (python#97999)
mpage
pushed a commit
to mpage/cpython
that referenced
this pull request
Oct 11, 2022
Copy link
Copy Markdown
Member
|
I cherry-picked this to python/importlib_resources@222aaed5. |
Sorry, something went wrong.
jaraco
pushed a commit
to jaraco/cpython
that referenced
this pull request
Feb 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the remaining importlib str.format() uses to f-strings.