FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-90699: Remove remaining `_Py_IDENTIFIER` stdlib usage by kumaraditya303 · Pull Request #99067 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

GH-90699: Remove remaining _Py_IDENTIFIER stdlib usage - #99067

Merged
miss-islington merged 14 commits into
python:mainfrom
kumaraditya303:rest-pyid
Nov 7, 2022
ConversationCommits (14)ChecksFiles changed
Merged

GH-90699: Remove remaining _Py_IDENTIFIER stdlib usage#99067
miss-islington merged 14 commits into
python:mainfrom
kumaraditya303:rest-pyid

Conversation

kumaraditya303 commented Nov 3, 2022 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

Automerge-Triggered-By: GH:ericsnowcurrently

bedevere-bot mentioned this pull request Nov 3, 2022
Closed
ericsnowcurrently requested changes Nov 3, 2022
View reviewed changes
Comment thread Include/internal/pycore_global_strings.h Outdated
Comment thread Modules/_testcapimodule.c
Comment thread Modules/_datetimemodule.c

bedevere-bot commented Nov 3, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

kumaraditya303 marked this pull request as ready for review November 4, 2022 11:20
kumaraditya303 requested review from a team, abalkin and pganssle as code owners November 4, 2022 11:20
ericsnowcurrently approved these changes Nov 4, 2022
View reviewed changes

ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

(Thanks for the changes.)

ericsnowcurrently requested changes Nov 7, 2022
View reviewed changes

ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

One small thing and then LGTM.

Also, were you planning on removing _Py_IDENTIFIER() from Programs/_testembed.c? (Presumably we'd drop test_unicode_id_init().) Then again, that should probably be part of the issue/PR that actually eliminates _Py_IDENTIFIER().

Comment thread Modules/ossaudiodev.c

bedevere-bot commented Nov 7, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

kumaraditya303 commented Nov 7, 2022

Copy link
Copy Markdown
Contributor Author

Then again, that should probably be part of the issue/PR that actually eliminates _Py_IDENTIFIER().

Yeah, will remove that in PR which removes _Py_IDENTIFIER together, no plans for that though.

ericsnowcurrently approved these changes Nov 7, 2022
View reviewed changes

ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

ericsnowcurrently changed the title GH-90699: Remove remaining _Py_IDENTIFIER usage GH-90699: Remove remaining _Py_IDENTIFIER stdlib usage Nov 7, 2022
miss-islington merged commit be0d500 into python:main Nov 7, 2022

vstinner commented Nov 7, 2022

Copy link
Copy Markdown
Member

Refleak buildbots fail since this commit. Example:
https://buildbot.python.org/all/#/builders/217/builds/878

2 tests failed:
    test_finalization test_gc

Example:

$ make && ./python -m test -R 3:3 test_finalization -m test_legacy_self_cycle 
...
test_finalization leaked [1, 1, 1] references, sum=3
...

cc @pablogsal

pablogsal commented Nov 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Please @ericsnowcurrently @kumaraditya303 take a look, otherwise we will need to revert if is not fixed in 24h per our buildbot policy.

ericsnowcurrently commented Nov 8, 2022

Copy link
Copy Markdown
Member

If @kumaraditya303 doesn't get to it first, I'll tackle this first thing tomorrow morning (~15 hours from now).

kumaraditya303 deleted the rest-pyid branch November 8, 2022 05:23

kumaraditya303 commented Nov 8, 2022

Copy link
Copy Markdown
Contributor Author

#99236 fixes the refleak.

vstinner commented Nov 8, 2022

Copy link
Copy Markdown
Member

The PR got merged, I confirm that it does fix the issue:

$ ./python -m test -R 3:3 test_gc test_finalization
(...)
Tests result: SUCCESS

ericsnowcurrently commented Nov 8, 2022

Copy link
Copy Markdown
Member

Thanks, @kumaraditya303!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ericsnowcurrently ericsnowcurrently approved these changes
pganssle Awaiting requested review from pganssle pganssle is a code owner
abalkin Awaiting requested review from abalkin

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL